95818[FEATURE] Process system resource images without FAL
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 20
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php+12 −4
- typo3/sysext/core/Classes/Imaging/ImageProcessor.phpnew+55 −0
- typo3/sysext/core/Classes/Imaging/ImageResource.php+19 −0
- typo3/sysext/core/Classes/Imaging/LocallyProcessableInterface.phpnew+33 −0
- typo3/sysext/core/Classes/Imaging/SystemResourceImageProcessor.phpnew+114 −0
- typo3/sysext/core/Classes/Resource/File.php+7 −1
- typo3/sysext/core/Classes/SystemResource/Type/PackageResource.php+11 −1
- typo3/sysext/core/Classes/SystemResource/Type/ProcessedSystemResource.phpnew+100 −0
- typo3/sysext/core/Documentation/Changelog/14.3.x/Feature-110702-SystemResourceImageProcessing.rstnew+63 −0
- typo3/sysext/core/Tests/Functional/Imaging/SystemResourceImageProcessorTest.phpnew+74 −0
- typo3/sysext/core/Tests/Unit/Imaging/ImageProcessorTest.phpnew+72 −0
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+11 −0
- typo3/sysext/core/Tests/Unit/SystemResource/Type/ProcessedSystemResourceTest.phpnew+54 −0
- typo3/sysext/extbase/Classes/Service/ImageService.php+29 −0
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+27 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php+50 −16
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+65 −16
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+12 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+14 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+68 −3
Review log 46
-
Benni Mack uploaded patch set 1 09/14/26, 18:17
-
Benni Mack commented on patch set 1 09/14/26, 18:17
This is the Liskov/capability-interface variant, alternative to https://review.typo3.org/c/Packages/TYPO3.CMS/+/95814 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/95817. File and PackageResource both implement the new LocallyProcessableInterface, so ImageProcessor dispatches on ProcessableFileInterface/LocallyProcessableInterface capability rather than a concrete-type instanceof at the call sites. Please compare all three; only one is meant to land. -
core-ci voted on patch set 1 V -1 09/14/26, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108547
-
Benni Mack uploaded patch set 2
V -109/14/26, 19:54 -
core-ci voted on patch set 2 V -1 09/14/26, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108551
-
Benni Mack abandoned the change 09/23/26, 15:29
I think https://review.typo3.org/c/Packages/TYPO3.CMS/+/95956 is better