Review main Abandoned

95818[FEATURE] Process system resource images without FAL

Benni Mack CR 0 V -1 Hard +890 −52 updated 09/23/26, 15:29

Commit message

Extension resources ("EXT:"/"PKG:" paths) rendered as images via the
Fluid image ViewHelpers or the TypoScript imgResource content object
previously had to be resolved through the File Abstraction Layer,
which relied on the "fallback storage" transparently mapping any
path within the public web directory to a sys_file record. Every
processed extension resource image therefore implicitly created (or
looked up) an indexed file record editors could see in the file
list, even though the file is not part of any file storage.

The new SystemResourceImageProcessor resizes, crops and converts
such images directly via GraphicalFunctions::resize(), the same way
GifBuilder does. Processed variants are written to
typo3temp/assets/images/ and are never tracked in sys_file or
sys_file_processedfile.

A new capability interface, LocallyProcessableInterface, is
implemented both by File (which already implements the existing
SystemResourceInterface) and by PackageResource. The new
ImageProcessor service is the single entry point the Fluid image
ViewHelpers use to process a resolved image: it dispatches on
capability - anything implementing ProcessableFileInterface (File,
FileReference) takes the regular FAL processing chain, everything
else is handled by SystemResourceImageProcessor. Callers no longer
branch on the concrete type of the resolved image themselves, and
a further kind of locally processable, non-FAL image resource could
be added without changing ImageProcessor at all.

For the non-FAL case, ImageProcessor wraps the result as a new
ProcessedSystemResource. Unlike SystemResourceImageProcessor's own
ImageResource DTO (kept unchanged, as ContentObjectRenderer's
existing ImageContentObject/GifBuilder integration relies on its
getFullPath() for legitimate, pre-existing reasons),
ProcessedSystemResource never exposes a local filesystem path -
only content, metadata and its public URL, mirroring how a FAL
ProcessedFile relates to a File.

This is a second alternative to Gerrit change 95814
(Change-Id I037a991efe5300e48635dd78ace53ecc3b9163c5) and 95817
(Change-Id I28c061bd548d14c20893c9a6a79905345b06cc39): rather than
consolidating the instanceof branch into one service (95817), the
resolved image types are made to genuinely satisfy a shared
capability interface, so the branch only remains where a real
semantic difference exists (how the result is cached). Reviewers
should compare all three; only one is meant to land.

This is independent of the still-existing FAL fallback storage and
does not change how paths within regular file storages are
resolved.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 20

Review log 46

  1. Benni Mack uploaded patch set 1 09/14/26, 18:17

  2. Benni Mack commented on patch set 1 09/14/26, 18:17

    This is the Liskov/capability-interface variant, alternative to https://review.typo3.org/c/Packages/TYPO3.CMS/+/95814 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/95817. File and PackageResource both implement the new LocallyProcessableInterface, so ImageProcessor dispatches on ProcessableFileInterface/LocallyProcessableInterface capability rather than a concrete-type instanceof at the call sites. Please compare all three; only one is meant to land.
  3. core-ci voted on patch set 1 V -1 09/14/26, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108547

  4. Benni Mack uploaded patch set 2 V -1 09/14/26, 19:54

  5. core-ci voted on patch set 2 V -1 09/14/26, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108551

  6. Benni Mack abandoned the change 09/23/26, 15:29