Review main Merged

95822[BUGFIX] Resolve redirects to record targets

Georg Ringer CR +2 V +2 Normal +63 −1 updated 10/15/26, 16:09

Commit message

RedirectService::bootFrontendController() attaches page information
and TypoScript to the request, but returns only the
ContentObjectRenderer it created. getUriFromCustomLinkDetails() then
handed the untouched original request to the link builder, so
DatabaseRecordLinkBuilder found no "frontend.page.information" and
died with "Call to a member function getId() on null".

The enriched request is now taken from the ContentObjectRenderer,
which is where bootFrontendController() left it. Page links were
unaffected because PageLinkBuilder does not need those attributes.

v13 kept the state in the global TypoScriptFrontendController, so
this surfaced when that was removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 911

  1. Georg Ringer uploaded patch set 1 09/14/26, 20:23

  2. Georg Ringer commented on patch set 1 09/14/26, 20:24

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/14/26, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108554

  4. Benni Mack voted on patch set 1 CR +1 09/15/26, 05:51

  5. Georg Ringer rebased onto patch set 2 CR +1 V +1 10/02/26, 09:38

  6. core-ci voted on patch set 2 V +1 10/02/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109897

  7. Georg Ringer voted on patch set 2 CR +1 V +1 10/15/26, 12:07

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 10/15/26, 12:13

  9. Benni Mack voted on patch set 2 CR +1 V +1 10/15/26, 13:04

  10. Georg Ringer voted on patch set 2 CR +2 V +2 10/15/26, 16:09

  11. Georg Ringer merged patch set 3 10/15/26, 16:09