Review main Merged

95823[BUGFIX] Fix stacking order of the color picker popup

Georg Ringer CR +2 V +2 Easy +13 −0 updated 10/02/26, 09:16

Commit message

The popover container of the color picker ships with a
"transform: translate(0)", which opens a stacking context while the
container itself stays unpositioned at "z-index: auto". The
"z-index: 999999" of the popup inside is scoped to that context and
has no effect outside of it, so the picker is painted below every
positioned backend element that carries a z-index: the FormEngine
tab bar, the character counter and the date picker controls.

The container is now positioned and placed on the dropdown layer.
With a width and height of zero this has no layout impact, and the
popup keeps its containing block, which the transform established
already.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Georg Ringer uploaded patch set 1 09/14/26, 20:36

  2. Georg Ringer commented on patch set 1 09/14/26, 20:36

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/14/26, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108555

  4. Simon Schaufelberger commented on patch set 1 09/14/26, 22:02

    @georg.ringer@gmail.com why does this patch have a relation chain? did you forget to reset your HEAD?
  5. Georg Ringer rebased onto patch set 2 V +1 09/15/26, 07:02

  6. Benni Mack commented on patch set 2 09/15/26, 07:02

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 09/15/26, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108582

  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/16/26, 17:49

  9. Wouter Wolters voted on patch set 2 CR +1 V +1 09/16/26, 17:55

  10. Georg Ringer updated the commit message in patch set 3 CR +1 V +1 10/02/26, 06:32

  11. Wouter Wolters voted on patch set 3 CR +1 V +1 10/02/26, 06:35

  12. core-ci voted on patch set 3 V +1 10/02/26, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109869

  13. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/02/26, 07:08

  14. Georg Ringer voted on patch set 3 CR +2 V +2 10/02/26, 09:05

  15. Georg Ringer merged patch set 4 10/02/26, 09:16