Review main Merged

95825[TASK] Skip mechanical commits in git blame

Georg Ringer CR +2 V +2 Normal +100 −0 updated 09/16/26, 09:48

Commit message

Tree wide mechanical changes bury the commit that actually wrote a
line. Blaming the head of GeneralUtility points at the PSR-2 run and
at php-cs-fixer instead of the changes that introduced the code.

A .git-blame-ignore-revs file now lists such commits. GitHub applies
it to its blame view on its own, locally it is enabled with
"git config blame.ignoreRevsFile .git-blame-ignore-revs".

The list was collected from the commits touching four digit numbers
of files and reduced to those that changed no behaviour at all: the
namespace move, the copyright header series, the PSR-2 and PSR-12
runs, php-cs-fixer runs, removal of closing tags and of @author,
@package and @param annotations, and comparable clean ups.

Note that lines a listed commit added itself keep pointing at it,
git can only pass on what a commit modified.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Mathias Brodala +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Georg Ringer uploaded patch set 1 09/14/26, 21:39

  2. Georg Ringer commented on patch set 1 09/14/26, 21:41

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/14/26, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108557

  4. Mathias Brodala voted on patch set 1 CR +1 09/16/26, 06:10

  5. Georg Ringer rebased onto patch set 2 CR +1 V +1 09/16/26, 09:18

  6. Mathias Brodala voted on patch set 2 CR +1 09/16/26, 09:18

  7. Mathias Brodala commented on patch set 2 V +1 09/16/26, 09:24

    Verified locally as described. E.g.: git blame typo3/sysext/core/Classes/Utility/GeneralUtility.php | grep "class GeneralUtility" b362e3667087 (TYPO3 Release Team 2015-10-09 00:08:57 +0200 53) class GeneralUtility git config blame.ignoreRevsFile .git-blame-ignore-revs git blame typo3/sysext/core/Classes/Utility/GeneralUtility.php | grep "class GeneralUtility" Blaming lines: 100% (2868/2868), done. 4612259a457f (Thomas Maroschik 2012-08-23 13:58:24 +0200 53) class GeneralUtility So the change "b362e3667087e37e8730ae6ffb7c47bc6fa73f87" ([TASK] Make TYPO3 Core PSR-2 standard compliant) was successfully ignored. That "4612259a457f43edaf723e1f4a8ef4ae89d00a34" ([TASK] Move and Namespace classes) still shows up here cannot be avoided I guess since this is basically the inception of the file.
  8. core-ci voted on patch set 2 V +1 09/16/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108663

  9. Benni Mack voted on patch set 2 CR +1 V +1 09/16/26, 09:45

  10. Georg Ringer voted on patch set 2 CR +2 V +2 09/16/26, 09:48

  11. Georg Ringer merged patch set 3 09/16/26, 09:48