95826[BUGFIX] Translate form flex form data structure without $LANG
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/form/Classes/Domain/Configuration/FlexformConfiguration/Processors/FinisherOptionGenerator.php2+7 −8
- typo3/sysext/form/Classes/Domain/Configuration/FlexformConfiguration/Processors/ProcessorInterface.php+0 −2
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+17 −2
- typo3/sysext/form/Tests/Functional/EventListener/DataStructureIdentifierListenerTest.php+131 −0
Review log 1620
-
Georg Ringer uploaded patch set 1 09/14/26, 21:50
-
core-ci voted on patch set 1 V +1 09/14/26, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108558
-
Georg Ringer rebased onto patch set 2
V +109/16/26, 09:18 -
core-ci voted on patch set 2 V +1 09/16/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108664
-
Georg Ringer commented on patch set 2 10/02/26, 16:22
This change is ready for review. -
Wouter Wolters voted on patch set 2 CR +1 V +1 10/02/26, 16:51
-
Oli Bartsch commented on patch set 2 10/02/26, 20:00
FinisherOptionGenerator.php:99Why do we keep this method? Could we just use the class property directly? -
Georg Ringer uploaded patch set 3
CR +1V +110/24/26, 06:05 -
Georg Ringer commented on patch set 3 10/24/26, 06:05
FinisherOptionGenerator.php:99ReplyDone -
core-ci voted on patch set 3 V +1 10/24/26, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112393
-
Wouter Wolters voted on patch set 3 CR +1 V +1 10/24/26, 07:02
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/06/26, 00:49
-
Josua Vogel uploaded patch set 4
CR +1V +111/10/26, 11:20 -
Josua Vogel voted on patch set 4 CR +1 11/10/26, 11:21
-
Josua Vogel commented on patch set 4 11/10/26, 11:23
added a functional test for the FinisherOptionGenerator path the issue reports (fails with "Undefined global variable $LANG" without the fix), a tearDown() resetting $GLOBALS['TYPO3_REQUEST'], and turned the test comment into a docblock without the issue URL. -
core-ci voted on patch set 4 V +1 11/10/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113888
-
Josua Vogel voted on patch set 4 V +1 11/10/26, 12:59
-
Benni Mack voted on patch set 4 CR +1 V +1 11/10/26, 14:32
-
Benni Mack voted on patch set 4 CR +2 V +2 11/10/26, 14:40
-
Benni Mack merged patch set 5 11/10/26, 14:40