Review main Merged

95836[BUGFIX] Keep disabled doc header buttons disabled

Oli Bartsch CR +2 V +2 Normal +128 −35 updated 09/16/26, 10:18

Commit message

While FormEngine was loading, the doc header buttons were disabled
one by one, and all of them were enabled again once it was ready.
That enable pass could not tell a button it had disabled itself
from one the core or an extension had disabled on purpose, so any
button set up with setDisabled(true) turned operable.

The loading block is now applied to the button bar as a whole: it
is rendered "inert" as long as the ui block is shown, and
FormEngine merely releases it again. The state of the single
buttons is never written, which keeps setDisabled(true) intact by
construction.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 1014

  1. Oli Bartsch uploaded patch set 1 09/15/26, 06:31

  2. Oli Bartsch uploaded patch set 2 09/15/26, 07:15

  3. Garvin Hicking commented on patch set 2 CR +1 V +1 09/15/26, 07:23

    (Note I do not fully know the specifics and browser support of 'inert', but it "works on my machine")
  4. core-ci voted on patch set 2 V +1 09/15/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108583

  5. core-ci voted on patch set 1 V -1 09/15/26, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108576

  6. Oli Bartsch commented on patch set 2 09/15/26, 08:59

    Reply

    Chrome 102 and Safari 15.5 (both May 2022) and Firefox 112 (April 2023).
  7. core-ci voted on patch set 1 V -1 09/15/26, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108576

  8. Oli Bartsch rebased onto patch set 3 CR +1 V +1 09/16/26, 05:47

  9. core-ci voted on patch set 3 V +1 09/16/26, 05:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108657

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 09/16/26, 06:51

  11. Georg Ringer voted on patch set 3 CR +1 V +1 09/16/26, 07:16

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/16/26, 08:03

  13. Oli Bartsch voted on patch set 3 CR +2 V +2 09/16/26, 10:18

  14. Oli Bartsch merged patch set 4 09/16/26, 10:18