95836[BUGFIX] Keep disabled doc header buttons disabled
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 11
- Build/Sources/Sass/component/_module.scss+4 −0
- Build/Sources/TypeScript/backend/form-engine.ts+8 −12
- Build/tests/packages/playwright_helper/Classes/EventListener/AddDisabledDocHeaderButtonListener.phpnew+63 −0
- Build/tests/playwright/e2e/form-engine/doc-header-blocking.spec.tsnew+34 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+9 −18
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+4 −0
- typo3/sysext/backend/Resources/Private/Layouts/Module.fluid.html+1 −1
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.fluid.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+2 −2
- typo3/sysext/info/Resources/Private/Layouts/Module.fluid.html+1 −1
Review log 1014
-
Oli Bartsch uploaded patch set 1 09/15/26, 06:31
-
Oli Bartsch uploaded patch set 2 09/15/26, 07:15
-
Garvin Hicking commented on patch set 2 CR +1 V +1 09/15/26, 07:23
(Note I do not fully know the specifics and browser support of 'inert', but it "works on my machine") -
core-ci voted on patch set 2 V +1 09/15/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108583
-
core-ci voted on patch set 1 V -1 09/15/26, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108576
-
Oli Bartsch commented on patch set 2 09/15/26, 08:59
Reply
Chrome 102 and Safari 15.5 (both May 2022) and Firefox 112 (April 2023). -
core-ci voted on patch set 1 V -1 09/15/26, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108576
-
Oli Bartsch rebased onto patch set 3
CR +1V +109/16/26, 05:47 -
core-ci voted on patch set 3 V +1 09/16/26, 05:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108657
-
Garvin Hicking voted on patch set 3 CR +1 V +1 09/16/26, 06:51
-
Georg Ringer voted on patch set 3 CR +1 V +1 09/16/26, 07:16
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/16/26, 08:03
-
Oli Bartsch voted on patch set 3 CR +2 V +2 09/16/26, 10:18
-
Oli Bartsch merged patch set 4 09/16/26, 10:18