Review 14.3 Merged

95838[BUGFIX] Avoid invalidly showing login form when opening a shared link

Benjamin Franzke CR +2 V +2 Normal +116 −27 updated 09/15/26, 11:58

Commit message

When a shared URL is linked from an external site, e.g.
a webbased mail client, the user cookie is omitted by
the user agent due to SameSite=strict setting on our session
cookies. This causing our controllers to assume that the user
is not logged in.

The backend route therefore redirects to the login route
which shows a login form that is misleading for several reasons:

  * It will accept any password
  * It can be skipped by reloading the form
  * It will not reenforce MFA

All three hickups aren't security issues, but UX fails,
because the user is already logged in but is enforced
to relogin anyway.

Note: Since the handling of the `required` flag
is moved from the `RouteDispatcher` into `ReferrerEnforcer`
directly, the flag is now added to all unit test
invocations. Prior unit test runs did not list
that flag, since `ReferrerEnforcer` only ran
if a route was set to be `required`, that means
they all implied `required`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 46

  1. Benjamin Franzke commented on patch set 1 09/15/26, 06:54

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Http/Security/ReferrerEnforcer.php * typo3/sysext/install/Classes/Middleware/Maintenance.php
  2. Benjamin Franzke uploaded patch set 2 09/15/26, 06:55

  3. core-ci voted on patch set 1 V -1 09/15/26, 06:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108579

  4. core-ci voted on patch set 2 V +1 09/15/26, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108581

  5. Benjamin Franzke commented on patch set 2 CR +2 V +2 09/15/26, 11:58

    This change is ready for review.
  6. Benjamin Franzke merged patch set 3 09/15/26, 11:58