Review main Merged

95844[TASK] Isolate global state in SetCookieServiceTest

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 09/15/26, 08:11

Commit message

SetCookieServiceTest sets the cookie domain in $GLOBALS and does not
reset it. Since global state is only backed up for test classes which
opt in, a following test like UserSessionManagerTest resolves a wrong
cookie scope in randomized unit test runs and fails.

The test class now opts in to the global state backup.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 09/15/26, 07:55

  2. Benjamin Franzke commented on patch set 1 CR +1 V +1 09/15/26, 07:57

    Sorry and thanks!
  3. core-ci voted on patch set 1 V +1 09/15/26, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108591

  4. Stefan Bürk commented on patch set 1 CR +2 V +2 09/15/26, 08:11

    Merging as test related only.
  5. Stefan Bürk merged patch set 2 09/15/26, 08:11