Review 13.4 Work in progress Stale

95851[BUGFIX] Passthrough SiteConfigurationWriteException in SiteSettingsService

Benjamin Franzke CR 0 V 0 Easy +33 −13 updated 09/15/26, 10:15

Commit message

SiteSettingsService::writeSettings() silently caught
SiteConfigurationWriteException and never re-threw it. Callers had
no way to detect whether a settings write had actually succeeded.

The exception is now re-thrown after the flash message is enqueued,
so callers can react to the failure appropriately. The code cache
flush is intentionally skipped on failure as nothing was written.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/51/95851/1 && git checkout FETCH_HEAD
Cherry-pick onto 13.4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/51/95851/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 95851 [BUGFIX] Passthrough SiteConfigurationWriteException in SiteSettingsService This change

  2. 13.4 95849[BUGFIX] Suppress warnings from `GeneralUtility::writeFile()` This change is based on it Merged Benjamin Franzke CR +2 V +2 → main, 14.3 Easy +3 −3

    The chain has patch set 1 of 2, the changes above it need a rebase.

Issues 1

Files 3

Review log 12

  1. Benjamin Franzke uploaded patch set 1 09/15/26, 10:07

  2. core-ci voted on patch set 1 V +1 09/15/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108607