Review main Merged

95858[BUGFIX] Skip open document tracking on CLI

Florian Auderset CR +2 V +2 Easy +7 −0 updated 09/23/26, 16:43

Commit message

TrackOpenDocumentsEventListener reacts to every DataHandler write to keep
the recent documents list of the backend user up to date. Its guard only
checks whether the current request is a backend request, which is true on
CLI as well. The "_cli_" backend user never gets a user session, though,
so reading its module data raises

  Call to a member function getIdentifier() on null

in AbstractUserAuthentication::getModuleData() and aborts the command. Any
DataHandler write on CLI is affected: upgrade wizards, scheduler tasks and
custom commands alike.

There is no recent documents list to maintain on CLI, so the listener now
bails out early in that case, the same way BackendUtility::setUpdateSignal()
already does.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Florian Auderset uploaded patch set 1 09/15/26, 13:48

  2. Florian Auderset commented on patch set 2 09/15/26, 13:51

    Published edit on patch set 1.
  3. Florian Auderset marked it ready for review 09/15/26, 13:52

  4. core-ci voted on patch set 1 V +1 09/15/26, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108625

  5. core-ci voted on patch set 2 V +1 09/15/26, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108626

  6. Wouter Wolters voted on patch set 2 CR +1 09/16/26, 19:13

  7. Georg Ringer voted on patch set 2 CR +1 V +1 09/16/26, 19:59

  8. Wouter Wolters voted on patch set 2 V +1 09/23/26, 15:47

  9. Benni Mack voted on patch set 2 CR +2 V +2 09/23/26, 16:43

  10. Benni Mack merged patch set 3 09/23/26, 16:43