Review main Merged

95860[TASK] Prefer native PHPDoc over custom `@phpstan-*` annotations

Elias Häußler CR +2 V +2 Normal +95 −155 updated 09/15/26, 18:51

Commit message

`@phpstan-*` annotations were added in the past to assure high
compatibility for static analyzers, IDEs and "core" PHP. Since most of
the types used for annotations like `@phpstan-param`, `@phpstan-var` and
`@phpstan-return` are understood by various static analyzeres and IDEs
nowadays, they can be safely written by their native counterparts. This
patch replaces all applicable occurrences of said annotations, while
keeping full PHPStan type support.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 68

  1. Elias Häußler uploaded patch set 1 09/15/26, 14:16

  2. core-ci voted on patch set 1 V -1 09/15/26, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108628

  3. Elias Häußler uploaded patch set 2 V -1 09/15/26, 14:26

  4. core-ci voted on patch set 2 V +1 09/15/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108629

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 09/15/26, 14:37

  6. Oliver Klee voted on patch set 2 CR +1 V +1 09/15/26, 14:49

  7. Georg Ringer voted on patch set 2 CR +2 V +2 09/15/26, 18:51

  8. Georg Ringer merged patch set 3 09/15/26, 18:51