Review main Abandoned

95861[BUGFIX] Return to module after record localization

Wouter Wolters CR +1 V +1 Normal +58 −20 updated 11/09/26, 14:12

Commit message

The localization wizard always uses the Page module as the return target
after creating a translated record. This sends editors away from the
Records module that opened the wizard.

Pass the originating module URL through the localization request and use
it as the return URL of the translated record edit form. Sanitize the
submitted URL before handing it to the localization handler.

Review

  • Code review CR +1
    • Simon Schaufelberger +1
  • Verified V +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1012

  1. Wouter Wolters uploaded patch set 1 09/15/26, 16:55

  2. core-ci voted on patch set 1 V +1 09/15/26, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108633

  3. Wouter Wolters marked it ready for review 09/15/26, 17:16

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/22/26, 11:01

  5. Stefan Bürk commented on patch set 1 CR -1 09/25/26, 20:23

    LocalizationController.php:454

    Not sure, I guess it would be more cleaner to add the redirectUrl (`?string`) directly to the `LocalizationInstructions` as property instead if parking and retrieving it through the `$additionalData` sink. $additionalData has no array shape, so no one can clearly see what's in it or not. What do you think ? (Or other reviewers). Personally I would love to have it directly in the instructions, thinking about our DeepL API based extensions of the company.

    Important-110697-LocalizationWizardReturnsToOriginatingModule.rst:11

    This file should go into the `14.3.x` folder due to the backport ...
  6. Wouter Wolters uploaded patch set 2 CR +1 V +1 09/26/26, 15:01

  7. Wouter Wolters commented on patch set 2 09/26/26, 15:01

    LocalizationController.php:454 Reply

    Done

    Important-110697-LocalizationWizardReturnsToOriginatingModule.rst:11 Reply

    Done
  8. core-ci voted on patch set 2 V +1 09/26/26, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109340

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/17/26, 18:02

  10. Georg Ringer commented on patch set 2 10/18/26, 06:37

  11. Oliver Klee voted on patch set 2 V +1 10/18/26, 09:22

  12. Benni Mack abandoned the change 11/09/26, 14:12