Review 13.4 Abandoned

95862[BUGFIX] Restore view button after mode switch

Wouter Wolters CR 0 V -1 Easy +48 −1 updated 10/07/26, 11:44

Commit message

Reset the language selection to the default language when switching
from language comparison to layout while all languages are selected.
This keeps the view webpage button available.

Review

  • Code review CR 0
  • Verified V -1
    • Sybille Peters -1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/15/26, 17:15

  2. core-ci voted on patch set 1 V +1 09/15/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108634

  3. Sybille Peters commented on patch set 1 V -1 09/16/26, 06:18

    This did not work for me. Is there anything else I should do? I cherry-picked the patch, flushed cache (via maintenance, so system cache as well), did a CTRL+shift+r in Backend, even logged out and logged in again. I could still reproduce the problem ("Layout" with no langauge selected, no "View webpage" button).
  4. Anton Danilov commented on patch set 1 09/16/26, 18:42

    Unresolved

    @typo3@wouterwolters.nl, I can confirm Sybille's result. The patch doesn't look like it's working, but it does. The language selection is persisted per backend user (stored in the be_users.uc field), so the broken state is simply still stored for a user who already had it. The patch only takes effect on the explicit "Layout" dropdown switch, or once the backend user settings are reset. If the persisted state is already "All languages" (-1), that switch is never triggered, so the stored value is never corrected. I'm unsure how to proceed here: is it enough to keep the patch as is and rely on users resetting their backend user settings (or switching the dropdown), or should the code be changed so that existing/persisted states are corrected automatically without user interaction?
  5. Georg Ringer abandoned the change 10/07/26, 11:44

  6. Georg Ringer commented on patch set 1 10/07/26, 11:44

    won't be done for 13.4 anymore