Review 13.4 Merged

95868[TASK] Upgrade to CKEditor 5 v48

Benjamin Franzke CR +2 V +2 Nightmare +5425 −4128 updated 09/16/26, 10:05

Commit message

CKEditor5 v48 removed most parts of customized builds, which means
that we can no longer opt-out from installing the umbrella package,
since CSS is now shipped in that package. We therefore follow
upstreams recommendation do pull in all packages via `ckeditor5`.

We still build individual modules though, in order to let
integrators decide which plugins to load.

Used commands:

  cd Build
  git rm -rf overrides/ckeditor5
  # removing all individual packages as suggested by
  # https://ckeditor.com/docs/ckeditor5/latest/updating/nim-migration/customized-builds.html#migration-steps
  npm remove \
    @ckeditor/ckeditor5-alignment \
    @ckeditor/ckeditor5-autoformat \
    @ckeditor/ckeditor5-basic-styles \
    @ckeditor/ckeditor5-block-quote \
    @ckeditor/ckeditor5-clipboard \
    @ckeditor/ckeditor5-code-block \
    @ckeditor/ckeditor5-core \
    @ckeditor/ckeditor5-editor-classic \
    @ckeditor/ckeditor5-engine \
    @ckeditor/ckeditor5-essentials \
    @ckeditor/ckeditor5-find-and-replace \
    @ckeditor/ckeditor5-font \
    @ckeditor/ckeditor5-fullscreen \
    @ckeditor/ckeditor5-heading \
    @ckeditor/ckeditor5-highlight \
    @ckeditor/ckeditor5-horizontal-line \
    @ckeditor/ckeditor5-html-support \
    @ckeditor/ckeditor5-icons \
    @ckeditor/ckeditor5-indent \
    @ckeditor/ckeditor5-inspector \
    @ckeditor/ckeditor5-language \
    @ckeditor/ckeditor5-link \
    @ckeditor/ckeditor5-list \
    @ckeditor/ckeditor5-mention \
    @ckeditor/ckeditor5-paragraph \
    @ckeditor/ckeditor5-paste-from-office \
    @ckeditor/ckeditor5-remove-format \
    @ckeditor/ckeditor5-select-all \
    @ckeditor/ckeditor5-show-blocks \
    @ckeditor/ckeditor5-source-editing \
    @ckeditor/ckeditor5-special-characters \
    @ckeditor/ckeditor5-style \
    @ckeditor/ckeditor5-table \
    @ckeditor/ckeditor5-theme-lark \
    @ckeditor/ckeditor5-ui \
    @ckeditor/ckeditor5-undo \
    @ckeditor/ckeditor5-upload \
    @ckeditor/ckeditor5-utils \
    @ckeditor/ckeditor5-watchdog \
    @ckeditor/ckeditor5-word-count
  npm install --save-dev patch-package
  # Required because CKEditor v48 is currently not compatible
  # with tsconfig option `strictNullChecks: false`
  npm install --save ckeditor5@^48.5.1
  npm install --save @ckeditor/ckeditor5-inspector@^5
  # Needed to use htmlnano's "minifyJs" module
  npm install --save-dev terser
  npm remove @ckeditor/ckeditor5-dev-utils
  npm run build

See:

 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.0.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.0.1
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.1.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.1.1
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.2.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.3.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.4.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.5.0
 - https://github.com/ckeditor/ckeditor5/releases/tag/v48.5.1

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 149

Show 129 more files

Review log 34

  1. Benjamin Franzke uploaded patch set 1 09/16/26, 06:33

  2. core-ci voted on patch set 1 V +1 09/16/26, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108659

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/16/26, 10:05

  4. Benjamin Franzke merged patch set 2 09/16/26, 10:05