Review 14.3 Merged

95876[BUGFIX] Add error handling for Redis commands in RedisSessionBackend

Benni Mack CR +2 V +2 Normal +168 −5 updated 09/16/26, 19:41

Commit message

The collectGarbage() method silently discards del() failures
when removing expired sessions. If del() returns false (e.g. due
to permission errors or connection issues), the failure goes
unnoticed.

Add a logRedisCommandFailure() helper method (consistent with
RedisBackend) and check del() return values in collectGarbage(),
logging a warning on failure.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 813

  1. Benni Mack commented on patch set 1 09/16/26, 13:25

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Session/Backend/RedisSessionBackend.php * typo3/sysext/core/Tests/Unit/Session/Backend/RedisSessionBackendTest.php
  2. Benni Mack commented on patch set 2 09/16/26, 13:25

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/16/26, 13:25

  4. core-ci voted on patch set 2 V -1 09/16/26, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108687

  5. core-ci voted on patch set 1 V -1 09/16/26, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108686

  6. Benni Mack commented on patch set 3 V -1 09/16/26, 13:55

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V -1 09/16/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108690

  8. Benni Mack commented on patch set 4 V -1 09/16/26, 14:14

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V -1 09/16/26, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108695

  10. Wouter Wolters uploaded patch set 5 V -1 09/16/26, 16:52

  11. core-ci voted on patch set 5 V +1 09/16/26, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108705

  12. Benni Mack voted on patch set 5 CR +2 V +2 09/16/26, 19:40

  13. Benni Mack merged patch set 6 09/16/26, 19:41