95880[TASK] Streamline temporary file cleanup in unit tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+8 −20
- typo3/sysext/core/Tests/Unit/Imaging/GraphicalFunctionsTest.php+10 −7
- typo3/sysext/core/Tests/Unit/Imaging/GraphicsCanvasTest.php+10 −12
- typo3/sysext/core/Tests/Unit/Localization/Loader/XliffLoaderTest.php+5 −8
- typo3/sysext/core/Tests/Unit/Localization/LanguagePackStatesStoreTest.php+1 −6
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Package/Cache/PackageStatesPackageCacheTest.php+7 −9
- typo3/sysext/form/Tests/Unit/DependencyInjection/FormYamlCollectorConfiguratorTest.php+6 −23
Review log 79
-
Wouter Wolters uploaded patch set 1 09/16/26, 16:02
-
Oliver Klee commented on patch set 1 09/16/26, 16:07
Cleanup that needs to take place even if a test fails or throws an exception should happen in `tearDown()` instead. We could put the paths to unlink in a property for this. -
Oliver Klee commented on patch set 1 09/16/26, 16:07
Or we could convert these two tests into functional tests (with the DB disabled). I'd consider that the cleanest solution. -
core-ci voted on patch set 1 V +1 09/16/26, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108701
-
Wouter Wolters uploaded patch set 2
V +109/16/26, 16:35 -
core-ci voted on patch set 2 V +1 09/16/26, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108704
-
Benni Mack voted on patch set 2 CR +2 V +2 09/23/26, 01:53
-
Benni Mack merged patch set 3 09/23/26, 01:53