Review main Merged

95881[TASK] Avoid PHPUnit notices for non-verifying test doubles

Wouter Wolters CR +2 V +2 Easy +16 −13 updated 09/19/26, 09:12

Commit message

Two imaging tests create accessible mocks without configuring
expectations. Two text extractor tests use mocks only to return a MIME
type. PHPUnit reports these as mocks without expectations.

Invoke the protected imaging helper without a mock and use stubs for
the text extractor file doubles.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/16/26, 16:10

  2. core-ci voted on patch set 1 V +1 09/16/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108703

  3. Oliver Klee commented on patch set 1 CR +1 V +1 09/16/26, 16:24

    14.3 and 13.4 aren't affected? (Haven't checked yet.)
  4. Wouter Wolters commented on patch set 1 09/16/26, 16:30

    Reply

    Only typo3/sysext/core/Tests/Unit/Imaging/GraphicalFunctionsTest.php is affected in 14.3 but not sure if we fixed all notices over there. I did for PHPunit 13 upgrade and these slipt through
  5. Georg Ringer voted on patch set 1 CR +2 V +2 09/19/26, 09:12

  6. Georg Ringer merged patch set 2 09/19/26, 09:12