Review main Merged

95884[TASK] Correct argument order in unit test assertions

Wouter Wolters CR +2 V +2 Easy +4 −4 updated 09/19/26, 09:22

Commit message

Several unit tests pass actual values before expected values to PHPUnit
assertions. This produces misleading failure messages and diffs.

Pass expected values first and actual results second in the affected
assertions.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 89

  1. Wouter Wolters uploaded patch set 1 09/16/26, 17:16

  2. Oliver Klee voted on patch set 1 CR +1 09/16/26, 17:24

  3. Oliver Klee commented on patch set 1 09/16/26, 17:24

    Are any of these changes relevant for 13.4 as well?
  4. core-ci voted on patch set 1 V +1 09/16/26, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108709

  5. Wouter Wolters commented on patch set 1 09/16/26, 17:37

    Reply

    Don't really think we need this in 13.4. The tests work. Only if they really fail the failure message is wrong.
  6. Oliver Klee commented on patch set 1 V +1 09/16/26, 17:47

    Reply

    Acknowledged
  7. Georg Ringer voted on patch set 1 CR +1 V +1 09/19/26, 09:10

  8. Georg Ringer voted on patch set 1 CR +2 V +2 09/19/26, 09:22

  9. Georg Ringer merged patch set 2 09/19/26, 09:22