Review main Merged

95887[BUGFIX] Base focus area on the processed image

Georg Ringer CR +2 V +2 Normal +116 −3 updated 09/17/26, 19:55

Commit message

The data-focus-area attribute of the image, media and thumbnail
ViewHelpers holds absolute pixel coordinates. They were calculated
from the dimensions of the original file, although a focus area is
stored relative to the crop area of its crop variant, and the
rendered image is that crop area scaled to its final size.

The coordinates therefore did not describe the rendered image as
soon as a crop area was selected or the image was scaled down, and
could address a region completely outside the image boundaries.

The processed image is now used as the basis, so the coordinates
always refer to the img tag they are rendered on.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 810

  1. Georg Ringer uploaded patch set 1 09/16/26, 18:28

  2. Georg Ringer commented on patch set 2 09/16/26, 18:29

    Published edit on patch set 1.
  3. Georg Ringer commented on patch set 2 09/16/26, 18:30

    This change is ready for review.
  4. core-ci voted on patch set 1 V +1 09/16/26, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108714

  5. core-ci voted on patch set 2 V +1 09/16/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108715

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 09/17/26, 16:23

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 09/17/26, 17:00

    Ouch!!!
  8. Benni Mack voted on patch set 2 CR +1 V +1 09/17/26, 19:01

  9. Georg Ringer voted on patch set 2 CR +2 V +2 09/17/26, 19:02

  10. Georg Ringer merged patch set 3 09/17/26, 19:55