Review main Merged Breaking

95888[!!!][BUGFIX] Key ObjectStorage validation results by position

Georg Ringer CR +2 V +2 Normal +121 −0 updated 10/17/26, 13:09

Commit message

CollectionValidator built the property path of a collection element
from the key the collection yields while iterating. For ObjectStorage
that key is the spl_object_hash() of the element, so validation
results were stored below a path that no consumer could address:
form field ViewHelpers name the same element by its position.

Elements of an ObjectStorage are now keyed by their position, the way
a plain array already behaved.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Torben Hansen +1
    • Alexander Schnitzler +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Torben Hansen +1
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 910

  1. Georg Ringer uploaded patch set 1 09/16/26, 19:12

  2. Georg Ringer commented on patch set 1 09/16/26, 19:13

    This change is ready for review.
  3. Simon Schaufelberger voted on patch set 1 CR +1 09/16/26, 19:17

  4. core-ci voted on patch set 1 V +1 09/16/26, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108716

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 09/16/26, 19:23

  6. Torben Hansen voted on patch set 1 CR +1 V +1 09/18/26, 12:01

  7. Benni Mack commented on patch set 1 10/07/26, 15:16

    would be great if you could also have a look here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/96335
  8. Alexander Schnitzler voted on patch set 1 CR +1 V +1 10/17/26, 06:25

  9. Benni Mack voted on patch set 1 CR +2 V +2 10/17/26, 13:09

  10. Benni Mack merged patch set 2 10/17/26, 13:09