Review main Ready for review

95894[BUGFIX] Fix selected state of backend action menu items

Georg Ringer CR +1 V +1 Normal +50 −1 updated 11/11/26, 08:40

Commit message

Since backend Extbase module requests take their arguments from
the full query string, request arguments contain "token", "route"
and "id". The ActionMenuItemViewHelper required the request to
carry no argument beyond those of a menu item, so no option was
ever marked as selected.

The check is now the other way around and key aware: an item is
selected if all of its own arguments match the current request.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/94/95894/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/94/95894/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Josua Vogel +1
  • Verified V +1 Needs a vote
    • Oliver Klee +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Georg Ringer uploaded patch set 1 09/16/26, 20:42

  2. Georg Ringer commented on patch set 1 09/16/26, 20:42

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/16/26, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108722

  4. Simon Schaufelberger commented on patch set 1 09/17/26, 08:59

    should we backport that to 13 as well since the bug report came from v12?
  5. Georg Ringer commented on patch set 1 09/17/26, 09:29

    Reply

    no priority issue
  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/17/26, 10:12

  7. Simon Schaufelberger commented on patch set 1 09/17/26, 10:12

    Reply

    Acknowledged
  8. Georg Ringer rebased onto patch set 2 CR +1 V +1 11/10/26, 18:50

  9. core-ci voted on patch set 2 V +1 11/10/26, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113937

  10. Josua Vogel voted on patch set 2 CR +1 V +1 11/11/26, 06:35

  11. Oliver Klee voted on patch set 2 V +1 11/11/26, 08:40