Review main Merged

95902[BUGFIX] Always fix permissions of created files

Georg Ringer CR +2 V +2 Easy +29 −7 updated 10/10/26, 09:06

Commit message

FileNode::fixSelf() only corrected the permissions of a newly
created file if the node also defined a target content. Writing
the content and fixing the permissions are two unrelated steps,
so they are decoupled now and permissions are fixed for every
successfully created file.

The unit test for the "file already exists" guard of createFile()
is corrected along the way: it expected exception code 1366398198
thrown by getRelativePathBelowSiteRoot() and therefore never
reached the guard it is named after.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Josua Vogel +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1112

  1. Georg Ringer uploaded patch set 1 09/17/26, 20:05

  2. Georg Ringer commented on patch set 1 09/17/26, 20:05

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/17/26, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108767

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/17/26, 22:38

  5. Josua Vogel voted on patch set 1 CR +1 V +1 09/26/26, 17:14

  6. Wouter Wolters voted on patch set 1 CR +1 V +1 09/27/26, 07:42

  7. Benni Mack voted on patch set 1 CR +1 V +1 09/29/26, 05:13

  8. Josua Vogel voted on patch set 1 V 0 10/08/26, 20:52

  9. Josua Vogel voted on patch set 1 V +1 10/08/26, 20:52

  10. Oliver Klee voted on patch set 1 CR +1 V +1 10/08/26, 21:11

  11. Georg Ringer voted on patch set 1 CR +2 V +2 10/10/26, 09:06

  12. Georg Ringer merged patch set 2 10/10/26, 09:06