Review main Merged

95904[BUGFIX] Quote container binary check in runTests.sh

Georg Ringer CR +2 V +2 Easy +1 −1 updated 09/18/26, 08:58

Commit message

The condition selecting the docker "--user" workaround leaves both
"$(uname)" and "${CONTAINER_BIN}" unquoted. With neither podman nor
docker installed, "${CONTAINER_BIN}" expands to nothing and the test
aborts with "[: =: unary operator expected" before the intended hint
"Selected container environment ... not found" is printed.

Quoting both expansions drops that stray message and resolves the
shellcheck finding SC2046 reported for this line.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 09/17/26, 21:27

  2. Georg Ringer commented on patch set 1 09/17/26, 21:33

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/17/26, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108770

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/17/26, 21:42

  5. Stefan Bürk voted on patch set 1 CR -1 09/18/26, 06:07

  6. Stefan Bürk updated the commit message in patch set 2 CR +1 V +1 09/18/26, 06:10

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 09/18/26, 06:10

  8. core-ci voted on patch set 2 V +1 09/18/26, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108791

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/18/26, 07:58

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 09/18/26, 08:45

  11. Stefan Bürk merged patch set 3 09/18/26, 08:58