Review main Merged

95905[BUGFIX] Tolerate an unresolvable itemsProcFunc when saving

Oli Bartsch CR +2 V +2 Normal +193 −3 updated 09/22/26, 06:07

Commit message

DataHandler composes the items of a check and of a radio field itself
before it accepts a value for them. Both did so without guarding what
that can cost.

`checkValueForCheck()` reads the declared items as optional and hands
them on as required one line later, so a field leaving all its boxes
to a processor ends the save with a TypeError.

Neither method catches `ItemsProcessorExecutionFailedException`, which
`ItemProcessingService` throws for anything a processor raises. The
editing form has caught it all along.

A processor that cannot run now leaves the boxes the field declares
for a checkbox, and no further item to compare against for a radio.

Defaults are applied for every column of a new record, so one such
field made every new record of its table fail, not only records the
field was submitted with.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 56

  1. Oli Bartsch uploaded patch set 1 09/17/26, 21:33

  2. core-ci voted on patch set 1 V +1 09/17/26, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108771

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/17/26, 21:46

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/19/26, 09:08

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 09/22/26, 06:07

  6. Oli Bartsch merged patch set 2 09/22/26, 06:07