Review main Merged

95907[BUGFIX] Compare skipped reaction fields unordered

Stefan Bürk CR +2 V +2 Easy +15 −4 updated 09/18/26, 05:42

Commit message

The create record reaction stores its field map in the JSON column
sys_reaction.fields and reports the fields it skipped in the order
that map lists them. MySQL normalises a JSON object on write and
orders its keys by length first and bytewise second, while mariadb,
sqlite and postgres keep the order of the written document. Two
assertions compared the reported fields including their order and
therefore failed on MySQL only.

The entries are now compared irrespective of their order, which is
not part of the response contract.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Stefan Bürk uploaded patch set 1 09/18/26, 03:33

  2. core-ci voted on patch set 1 V +1 09/18/26, 03:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108778

  3. core-ci commented on patch set 1 09/18/26, 03:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108779

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/18/26, 04:02

  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 09/18/26, 05:36

  6. Georg Ringer voted on patch set 1 CR +2 V +2 09/18/26, 05:42

  7. Georg Ringer merged patch set 2 09/18/26, 05:42