Review 14.3 Merged

95908[BUGFIX] Stop reading ext_emconf.php in the extension manager

Benni Mack CR +2 V +2 Hard +191 −132 updated 09/18/26, 17:15

Commit message

ext_emconf.php is no longer evaluated for package metadata since
TYPO3 v15, yet the extension manager still read it in three places.
Two of them were harmless leftovers, one hid a real defect.

The extension list rendered the description of an extension from a
merge with the ext_emconf.php array, because getAvailableExtensions()
never took it from the package metadata although MetaData carries it.
Without an ext_emconf.php the description was empty. The description
now comes from the package metadata, the merge is gone and the
remaining method is named after what it still does:
enrichExtensionsWithTerInformation().

The dependency check compared against the ext_emconf.php version when
the metadata version was missing. It never is; the fallback is gone.

Uploading a zip archive that carries no composer.json raised a
TypeError from json_decode(), because the file was read without a
check. It is an ExtensionManagerException now, as is an unreadable
composer.json. The version of an uploaded archive was read from
ext_emconf.php when composer.json declared none, although the upload
controller already parses "my_ext_1.2.3.zip" for the extension key.
The controller passes that version on. When neither the archive name
nor composer.json carries one, the upload is refused with a message
saying how to fix it. Until now such an extension was unpacked and
then dropped by the next package scan without any error, because a
package without a version is not registered in classic mode.

The 15.0 changelog claimed that loading such an extension throws an
exception. It does not: the package scan unregisters it silently and
only an explicit reload of the package information throws. The entry
describes this now. The 14.2 feature entry on ext_emconf.php linked
the form database storage feature where it meant the entry on the
extension title from composer.json.

EmConfUtility stays for the t3x download path, which still writes an
ext_emconf.php and goes away with the t3x.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 10

Review log 69

  1. Benni Mack commented on patch set 1 09/18/26, 06:10

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Documentation/Changelog/15.0/Breaking-109783-DeprecatedFunctionalityRemoved.rst * typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php
  2. Benni Mack commented on patch set 2 09/18/26, 06:10

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/18/26, 06:11

  4. core-ci voted on patch set 1 V -1 09/18/26, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108790

  5. core-ci voted on patch set 2 V -1 09/18/26, 06:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108792

  6. Benni Mack uploaded patch set 3 V -1 09/18/26, 16:59

  7. core-ci voted on patch set 3 V +1 09/18/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108818

  8. Benni Mack voted on patch set 3 CR +2 V +2 09/18/26, 17:15

  9. Benni Mack merged patch set 4 09/18/26, 17:15