Review main Merged

95915[BUGFIX] Add noreferrer for links even if site with host is configured

Nikita Hovratov CR +2 V +2 Normal +32 −31 updated 11/09/26, 21:23

Commit message

The decision whether to add the rel="noreferrer" attribute to links was
based on the locally configured sites of the TYPO3 instance. This is now
changed to only check for the request host. Only if request host and
URL host are identical, the attribute can be safely omitted.

It should not matter if a site is hosted on the same system. An external
link should always include the noreferrer attribute, even if you can
"trust yourself".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1419

  1. Nikita Hovratov uploaded patch set 1 09/18/26, 14:03

  2. core-ci voted on patch set 1 V -1 09/18/26, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108810

  3. Nikita Hovratov uploaded patch set 2 V -1 09/18/26, 14:25

  4. core-ci voted on patch set 2 V -1 09/18/26, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108811

  5. Nikita Hovratov uploaded patch set 3 V -1 09/18/26, 14:45

  6. core-ci voted on patch set 3 V +1 09/18/26, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108813

  7. Georg Ringer voted on patch set 3 CR +1 V +1 09/19/26, 09:07

  8. Nikita Hovratov rebased onto patch set 4 CR +1 V +1 10/16/26, 18:10

  9. core-ci voted on patch set 4 V +1 10/16/26, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111390

  10. Oliver Klee voted on patch set 4 CR +1 V +1 10/17/26, 17:09

  11. Guido Schmechel voted on patch set 4 CR +1 V +1 10/17/26, 22:00

  12. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/06/26, 09:24

  13. Benni Mack commented on patch set 4 11/09/26, 14:18

    LinkFactory.php:339

    why do we need the runtime Cache then btw?
  14. Georg Ringer uploaded patch set 5 CR +1 V +1 11/09/26, 20:31

  15. Georg Ringer commented on patch set 5 CR +1 V +1 11/09/26, 20:32

    LinkFactory.php:339 Reply

    Done
  16. Oliver Klee voted on patch set 5 CR +1 V +1 11/09/26, 20:37

  17. core-ci voted on patch set 5 V +1 11/09/26, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113778

  18. Benni Mack voted on patch set 5 CR +2 V +2 11/09/26, 21:23

  19. Benni Mack merged patch set 6 11/09/26, 21:23