Review main Merged

95922[DOCS] Remove DatabaseWriter from log rotation examples

Lina Wolf CR +2 V +2 Easy +0 −2 updated 09/19/26, 12:10

Commit message

The examples of the RotatingFileWriter changelog entry configure only
the RotatingFileWriter now. The additional DatabaseWriter was not part
of the default configuration of the deprecations logger and led to
unexpected database logging when the examples were copied.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Lina Wolf uploaded patch set 1 09/19/26, 08:31

  2. core-ci voted on patch set 1 V +1 09/19/26, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108837

  3. Georg Ringer voted on patch set 1 CR +1 V +1 09/19/26, 09:01

  4. Georg Ringer commented on patch set 1 09/19/26, 09:01

    but why only main?
  5. Lina Wolf commented on patch set 1 09/19/26, 09:02

    Reply

    The changelog is only rendered from main, but I wouldnt mind if youd rather backport
  6. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 09/19/26, 11:19

  7. Garvin Hicking commented on patch set 2 CR +2 V +2 09/19/26, 11:19

    Reply

    Yes lets backport for consistency
  8. Oliver Klee voted on patch set 2 CR +1 V +1 09/19/26, 11:22

  9. core-ci voted on patch set 2 V +1 09/19/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108853

  10. Garvin Hicking merged patch set 3 09/19/26, 12:10