Review main Abandoned

95939[BUGFIX] Fix inline file browser selection

Wouter Wolters CR -1 V 0 Normal +73 −1 updated 09/24/26, 16:08

Commit message

Open the file browser for inline sys_file selectors while keeping record
selectors in the database browser.

Review

  • Code review CR -1
    • Anton Danilov -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Wouter Wolters uploaded patch set 1 09/19/26, 20:40

  2. core-ci voted on patch set 1 V +1 09/19/26, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108862

  3. Wouter Wolters updated the commit message in patch set 2 V +1 09/24/26, 06:56

  4. Wouter Wolters marked it ready for review 09/24/26, 06:56

  5. core-ci voted on patch set 2 V +1 09/24/26, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109141

  6. Anton Danilov commented on patch set 2 CR -1 09/24/26, 09:53

    Unresolved

    This patch does not resolve issue #107638. The reported problem is that an integrator can register a **custom element browser** (any identifier via `ElementBrowserInterface::getIdentifier()`) and select it through the group field's `[appearance][elementBrowserType]`, and that the related inline field then opens that browser. Before the TCA type `file` refactor, `InlineControlContainer` honoured exactly that: ```php // InlineControlContainer.php if (isset($groupFieldConfiguration['appearance']['elementBrowserType'])) { $mode = $groupFieldConfiguration['appearance']['elementBrowserType']; } ``` with `Form/FieldControl/ElementBrowser.php` reading the same value. The value was passed verbatim as `mode`, so any registered browser identifier worked. The refactor hardcoded `data-mode="db"`, and this patch replaces that hardcode with ```php $elementBrowserType = $allowed === ['sys_file'] ? 'file' : 'db'; ``` It can only ever emit `file` or `db` - a custom registered identifier is unreachable by construction. So the exact scenario reported in #107638 - a custom element browser selected per field configuration remains broken. So I'd prefer this not be merged as-is with the `Resolves: #107638` trailer.
  7. Wouter Wolters abandoned the change 09/24/26, 16:08

    not the correct solution for the problem