95942[TASK] Add native type declarations to Extbase class constants
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/extbase/Classes/Configuration/ConfigurationManagerInterface.php+3 −3
- typo3/sysext/extbase/Classes/DomainObject/AbstractDomainObject.php+5 −5
- typo3/sysext/extbase/Classes/Mvc/View/JsonView.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/PropertyType.php+28 −28
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+4 −4
- typo3/sysext/extbase/Classes/Persistence/QueryInterface.php+15 −15
- typo3/sysext/extbase/Classes/Property/TypeConverter/ArrayConverter.php+3 −3
- typo3/sysext/extbase/Classes/Property/TypeConverter/CountryConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/DateTimeConverter.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/FloatConverter.php+2 −2
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+2 −8
- typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php+2 −8
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/PropertyCharacteristics.php+5 −5
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+1 −1
- typo3/sysext/extbase/Classes/Service/FileHandlingService.php+1 −1
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+1 −1
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+1 −1
- typo3/sysext/extbase/Classes/Utility/TypeHandlingUtility.php+2 −2
Review log 1011
-
Oliver Klee uploaded patch set 1 09/20/26, 08:15
-
Wouter Wolters commented on patch set 1 09/20/26, 08:24
If we have classes that can be extended in here via an extension this is a breaking change. Maybe mark it as such to prevent such cases? -
core-ci voted on patch set 1 V +1 09/20/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108883
-
Oliver Klee commented on patch set 1 09/21/26, 12:33
Reply
None of these constants are accessed using `static::`. So overwriting them in a subclass would have no effect. Does this make sense, or am I missing something? -
Wouter Wolters commented on patch set 1 09/21/26, 17:58
Reply
See https://3v4l.org/NWi6C#v8.5.10 for example. -
Simon Schaufelberger commented on patch set 1 09/21/26, 20:32
Reply
chance is 0.00000001% that somebody overwrote these values. 😊 -
Oliver Klee commented on patch set 1 09/22/26, 13:41
Reply
Exactly. My point was that it does not make sense to overwrite the constant in a subclass as that has no effect: https://3v4l.org/bFeNE -
Benni Mack voted on patch set 1 CR +1 V +1 09/22/26, 14:53
-
Benni Mack commented on patch set 1 09/22/26, 14:54
Reply Unresolved
agree. subclassing (which we don't cover with XCLASS for bw compat) + static calls only is really low-level -
Georg Ringer voted on patch set 1 CR +2 V +2 09/22/26, 17:15
-
Georg Ringer merged patch set 2 09/22/26, 17:15