95951[BUGFIX] Migrate media schema in upgrade wizard
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Wouter Wolters uploaded patch set 1 09/20/26, 14:11
-
core-ci voted on patch set 1 V +1 09/20/26, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108897
-
Markus Klein commented on patch set 1 09/20/26, 18:11
IMO this is not an optimal solution. Especially for automation. IMO the wizard must migrate the fields directly. For some wizards you shouldn't run change-commands on the DB to not destroy data, for some, like this one you should. This is a pitfall for admins in the long run. The IMO correct way is to have the upgrader run the add-commands and those wizards, which require a change, do this themselves. Otherwise this a back-and-forth between different commands/tools and you need to know what you may change and what you may not change during an upgrade, which is not good. -
Wouter Wolters uploaded patch set 2
V +109/20/26, 18:35 -
core-ci voted on patch set 2 V +1 09/20/26, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108908
-
Oliver Klee voted on patch set 2 V +1 09/20/26, 20:50
-
Markus Klein voted on patch set 2 CR +1 09/20/26, 20:52
-
Georg Ringer voted on patch set 2 CR +1 V +1 09/22/26, 17:17
-
Benni Mack voted on patch set 2 CR +2 V +2 09/22/26, 17:35
-
Benni Mack merged patch set 3 09/22/26, 17:35