Review 14.3 Merged

95952[TASK] Decouple file storage consumers from the sys_file_storage table

Stefan Bürk CR +2 V +2 Hard +404 −429 updated 09/20/26, 18:26

Commit message

Several places outside the FAL API talk to the sys_file_storage
table directly. They now go through StorageRepository, so the
storage definitions can move out of the database later on:

* sys_file.storage and tx_scheduler_task.file_storage get their
  select items from the new items processor function
  TcaItemsProcessorFunctions->populateFileStorages(), which lists
  the storages of the backend user, instead of a foreign_table.
  Both columns are declared in ext_tables.sql, as a select field
  with an itemsProcFunc gets no derived integer column.
* Read-only file mounts from user TSconfig resolve the default
  storage via StorageRepository->getDefaultStorageUid() instead of
  a direct query. The method resolves the uid without instantiating
  a storage, which would apply the mounts before they are complete.
* cleanup:localprocessedfiles determines the local storages via the
  repository instead of joining the table. This also removes the
  duplicate records reported when several local storages exist.

Without the foreign_table, the reference index no longer records
the relation of a sys_file record to its storage. Fixtures are
adjusted accordingly. EXT:impexp adds this relation on export, so
exports still contain the storage records the import needs to map
files to an equivalent storage of the target system.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 154

Show 134 more files

Review log 34

  1. Stefan Bürk uploaded patch set 1 09/20/26, 14:19

  2. core-ci voted on patch set 1 V +1 09/20/26, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108898

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 09/20/26, 18:26

  4. Stefan Bürk merged patch set 2 09/20/26, 18:26