95956[!!!][FEATURE] Process system resources without FAL persistence
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Markus Klein +1
- Simon Praetorius +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Simon Praetorius +1
- core-ci +1 CI
Issues 1
Files 52
- typo3/sysext/adminpanel/Classes/Service/ProcessedImageCollector.php4+13 −4
- typo3/sysext/adminpanel/Tests/Unit/Service/ProcessedImageCollectorTest.php+9 −7
- typo3/sysext/backend/Classes/Resource/Processing/DeferredBackendImageProcessor.php+13 −3
- typo3/sysext/core/Classes/Imaging/ImageManipulation/Area.php+40 −0
- typo3/sysext/core/Classes/Imaging/ImageProcessingInstructions.php+17 −3
- typo3/sysext/core/Classes/Imaging/ImageResource.php4+58 −13
- typo3/sysext/core/Classes/Resource/Event/AfterFileProcessingEvent.php+13 −8
- typo3/sysext/core/Classes/Resource/Event/BeforeFileProcessingEvent.php+13 −8
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php+4 −1
- typo3/sysext/core/Classes/Resource/Processing/AbstractTask.php+21 −8
- typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php+2 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+121 −40
- typo3/sysext/core/Classes/Resource/Processing/ProcessorRegistry.php+9 −0
- typo3/sysext/core/Classes/Resource/Processing/ResourceAwareProcessorInterface.phpnew+35 −0
- typo3/sysext/core/Classes/Resource/Processing/SvgImageProcessor.php+59 −12
- typo3/sysext/core/Classes/Resource/Processing/TaskInterface.php+3 −2
- typo3/sysext/core/Classes/Resource/Processing/TaskTypeRegistry.php+2 −2
- typo3/sysext/core/Classes/Resource/Service/ConfigurationService.php+4 −0
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+34 −9
- typo3/sysext/core/Classes/Resource/ImageSourceResolver.php3new+69 −0
Show 32 more files
- typo3/sysext/core/Classes/Resource/ProcessableFileInterface.php+7 −2
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+46 −1
- typo3/sysext/core/Classes/Resource/ProcessedResource.php9new+316 −0
- typo3/sysext/core/Classes/Resource/ProcessedResourceCache.php4new+155 −0
- typo3/sysext/core/Classes/Resource/ProcessedResourceInterface.phpnew+79 −0
- typo3/sysext/core/Classes/Resource/ResourceStorage.php2+7 −1
- typo3/sysext/core/Classes/SystemResource/Type/PackageResource.php+17 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110702-WidenedFalProcessingTaskInterfaces.rstnew+186 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110702-ProcessSystemResourceImages.rstnew+83 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_system_resources/Resources/Public/Images/typo3-logo.pngnewbinary
- typo3/sysext/core/Tests/Functional/Resource/OnlineMedia/Processing/PreviewProcessingTest.php+17 −0
- typo3/sysext/core/Tests/Functional/Resource/Service/FileProcessingServiceTest.phpnew+187 −0
- typo3/sysext/core/Tests/Unit/Imaging/ImageDimensionTest.php+20 −0
- typo3/sysext/core/Tests/Unit/Resource/Processing/AbstractTaskTest.phpnew+59 −0
- typo3/sysext/core/Tests/Unit/Resource/Processing/ProcessorRegistryTest.php+69 −7
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+77 −0
- typo3/sysext/core/Tests/Unit/Resource/ProcessedResourceCacheTest.phpnew+136 −0
- typo3/sysext/core/Tests/Unit/Resource/ProcessedResourceTest.phpnew+226 −0
- typo3/sysext/extbase/Classes/Service/ImageService.php2+7 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ImageViewHelper.php2+44 −19
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php5+48 −15
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+27 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+42 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php+25 −21
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+26 −11
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+7 −2
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+22 −6
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+107 −0
- typo3/sysext/frontend/Tests/Functional/Controller/ShowImageControllerTest.php+40 −0
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+41 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+4 −4
Review log 4363
Show 2338 earlier messages
-
Benni Mack uploaded patch set 1 09/21/26, 01:31
-
core-ci voted on patch set 1 V -1 09/21/26, 01:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108911
-
Benni Mack commented on patch set 2
V -109/22/26, 06:42Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 09/22/26, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108970
-
Benni Mack uploaded patch set 3
V +109/22/26, 08:02 -
Benni Mack updated the commit message in patch set 4 09/22/26, 08:02
-
core-ci voted on patch set 3 V -1 09/22/26, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108977
-
core-ci voted on patch set 4 V -1 09/22/26, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108978
-
Benni Mack uploaded patch set 5
V -109/22/26, 10:17 -
Benni Mack updated the commit message in patch set 6 09/22/26, 10:36
-
core-ci voted on patch set 5 V -1 09/22/26, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108988
-
core-ci voted on patch set 6 V +1 09/22/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108993
-
Benni Mack uploaded patch set 7
V +109/22/26, 14:51 -
Benni Mack marked it ready for review 09/22/26, 14:54
-
core-ci voted on patch set 7 V -1 09/22/26, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108996
-
Benni Mack uploaded patch set 8
V -109/22/26, 16:50 -
core-ci voted on patch set 8 V -1 09/22/26, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108999
-
Benni Mack rebased onto patch set 9
V -109/22/26, 17:41 -
core-ci voted on patch set 9 V -1 09/22/26, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109002
-
Benni Mack rebased onto patch set 10
V -109/23/26, 01:44 -
core-ci voted on patch set 10 V -1 09/23/26, 01:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109015
-
core-ci commented on patch set 10 09/23/26, 03:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109015
-
core-ci voted on patch set 10 V +1 09/23/26, 03:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109015
-
Simon Schaufelberger commented on patch set 10 09/23/26, 13:29
ProcessedResourceCache.php:45why is this public if it doesn't implement any interface and doesn't have a constructor?ResourceStorage.php:1408could we add a bit more context about the specific file? that would help for debuggingImageService.php:44can we add a bit more context about the file?ImageViewHelper.php:241same hereImageViewHelper.php:181same here -
Benni Mack uploaded patch set 11
V +109/23/26, 15:35 -
Benni Mack commented on patch set 11 09/23/26, 15:40
ProcessedResourceCache.php:45ReplyDoneResourceStorage.php:1408ReplyDoneImageService.php:44ReplyDoneImageViewHelper.php:241ReplyDoneImageViewHelper.php:181ReplyDone -
core-ci voted on patch set 11 V +1 09/23/26, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109071
-
Benni Mack rebased onto patch set 12
V +109/23/26, 16:07 -
Simon Schaufelberger commented on patch set 12 09/23/26, 16:13
Awesome, so much better now! Thank you! -
Simon Schaufelberger voted on patch set 12 CR +1 09/23/26, 16:13
-
core-ci voted on patch set 12 V -1 09/23/26, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109085
-
core-ci voted on patch set 12 V +1 09/23/26, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109085
-
Simon Praetorius commented on patch set 12 10/01/26, 09:18
(will look into it later today) -
Simon Praetorius commented on patch set 12 10/01/26, 13:05
ProcessedImageCollector.php:60Maybe it makes sense to add `getSize()` to the interface? I'd say that every processed resource should have a size.ProcessedImageCollector.php:65this could use `$processedFile->getImageDimension()` instead, either to just get the "prepared" values from a proper API or to just store the object directly instead of the individual values.ImageResource.php:62This could also use `$processedFile->getImageDimension()`ImageResource.php:72This could also use `$processedFile->getImageDimension()`ProcessedResource.php:169Maybe we can add `$request` as an optional parameter in the interface, since this method is probably here to stay? Even if the `GU::mI` can be avoided in the future, the request still needs to be provided in some way.ProcessedResourceCache.php:82`PathUtility::pathinfo()`ImageViewHelper.php:74... or resource object -
Simon Praetorius commented on patch set 12 10/01/26, 13:11
ImageViewHelper.php:74ReplyJust noticed that that isn't the case... but it should imho. So `ImageSourceResolver` could be extended to also resolve (some?) resource objects. Maybe `StaticResourceInterface` would be the right interface, since it's returned from `<f:resource>`? -
Benni Mack uploaded patch set 13
CR +1V +110/02/26, 10:16 -
Benni Mack commented on patch set 13 10/02/26, 10:17
ProcessedImageCollector.php:60ReplyDoneProcessedImageCollector.php:65ReplyDoneImageResource.php:62ReplyDoneImageResource.php:72ReplyDoneProcessedResource.php:169Replywell, if we would add it here, we would need to modify the FileInterface as well (which we could do, but I'd do it separately)ProcessedResourceCache.php:82ReplyDone -
Benni Mack commented on patch set 13 10/02/26, 10:17
ImageViewHelper.php:74ReplyDone
-
core-ci voted on patch set 13 V +1 10/02/26, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109903
-
Simon Praetorius commented on patch set 13 CR +1 10/02/26, 10:35
I'll do some manual tests, hopefully todayProcessedResource.php:169ReplyAcknowledged -
Simon Praetorius commented on patch set 13 10/04/26, 10:11
I tested several variants of image generation as well as automatic resource deletion, this worked perfectly for me, other than the mentioned relative path.ProcessedResource.php:172This part doesn't work for me on a site with a path segment as part of its base url (e. g. https://t3coredev.ddev.site/camino/). The images are generated in the correct folder, but `getAbsoluteWebPath` generates a relative web path (`typo3temp/...`), which leads to `/camino/typo3temp/assets/images/system/2555c5da2d684c8237c8794f6c1f989b/5f4d1598a7-328adef80b7e72303cac81e25b38d61e.svg` being resolved by the browser. Maybe everything should go through the resource API? Works: ``` <f:image image="{f:resource(identifier: 'EXT:theme_camino/Resources/Public/Icons/Extension.svg')}" width="300c" height="300c" /> ``` Doesn't work: ``` <f:image src="EXT:theme_camino/Resources/Public/Icons/Extension.svg" width="400c" height="300c" /> ``` -
Benni Mack uploaded patch set 14
CR +1V +110/05/26, 18:28 -
Benni Mack commented on patch set 14 10/05/26, 18:29
ProcessedResource.php:172ReplyThanks, I changed the place and added a quick test with PKG: can you recheck? If not, I will try again and also add a test to the Image VH again -
core-ci voted on patch set 14 V +1 10/05/26, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110145
-
Simon Praetorius commented on patch set 14 CR +1 V +1 10/05/26, 19:31
Works now as expected. Thanks! -
Oli Bartsch commented on patch set 14 10/05/26, 20:53
This seems to be wrong. -
Benni Mack uploaded patch set 15
CR +1V +110/06/26, 07:13 -
Benni Mack updated the commit message in patch set 16 10/06/26, 07:14
-
Benni Mack commented on patch set 16 10/06/26, 07:14
This change is ready for review.Reply
DoneProcessedResource.php:172ReplyDone -
core-ci voted on patch set 15 V -1 10/06/26, 07:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110193
-
core-ci voted on patch set 16 V -1 10/06/26, 07:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110194
-
Benni Mack commented on patch set 17
V -110/06/26, 07:39Published edit on patch set 16. -
core-ci voted on patch set 17 V +1 10/06/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110198
-
Markus Klein commented on patch set 17 10/06/26, 07:55
I'm not sure about the `typo3temp/` path. We never "share" this during releases currently. I would rather see this in `var/..` -
Benni Mack commented on patch set 17 10/06/26, 07:59
Reply
what exactly do you mean? processed resources are put into typo3temp/assets/ - this is where e.g. FAL zero Storage puts its images as well (typo3temp/assets/_processed). Putting the files in var/ (typo3temp/var in classic mode setups) does not allow direct access to these processed resources in composer mode based setups -
Markus Klein commented on patch set 17 10/06/26, 08:03
Reply
Yeah... forget it. Wrong thought on my side. Thanks. -
Markus Klein commented on patch set 17 10/06/26, 08:18
ImageSourceResolver.php:50can we narrow that a bit instead of object?ProcessedResource.php:187request as parameter an fallback to global? -
Benni Mack commented on patch set 17 10/06/26, 09:15
ProcessedResource.php:187Replywe discussed this in an earlier patch set - this would be a breaking change (as it also needs to be adapted in Fileinterface), which I want to do this in followup. -
Markus Klein commented on patch set 17 CR +1 10/06/26, 11:54
ProcessedResource.php:187ReplyAcknowledged -
Oli Bartsch commented on patch set 17 CR +1 V +1 10/07/26, 06:57
ImageSourceResolver.php:50ReplyI'd keep object here on purpose. It matches ResourceFactory::resolveFileObject(), which this delegates to, and the image argument of both image ViewHelpers is a plain object. With a narrowed union type, a wrong object from a template would become a TypeError. That skips the ViewHelper's catch, so instead of the Fluid exception with template context you'd get a fatal. The accepted types are listed in the class docblock anyways. -
Simon Praetorius voted on patch set 17 CR +1 V +1 10/08/26, 16:44
-
Benni Mack commented on patch set 17 CR +2 V +2 10/08/26, 19:55
ImageSourceResolver.php:50ReplyDone -
Benni Mack merged patch set 18 10/08/26, 19:55