Review main Merged

95957[TASK] Un-mark Connection::quoteIdentifier() override as deprecated

Till Hörner CR +2 V +2 Easy +2 −1 updated 09/25/26, 09:10

Commit message

Since #110254, `TYPO3\CMS\Core\Database\Connection::quoteIdentifier()`
overrides the deprecated Doctrine DBAL method. PHPStan still detects
the override as deprecated, as the `@deprecated` is inherited. Mark it
explicitly as not-deprecated.

https://phpstan.org/writing-php-code/phpdocs-basics#deprecations

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 913

  1. Till Hörner uploaded patch set 1 09/21/26, 08:23

  2. core-ci voted on patch set 1 V -1 09/21/26, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108933

  3. Oliver Klee commented on patch set 1 09/21/26, 09:03

    We'll then need to add `@not-deprecated` to the allowed PHPDoc annotations in the integrity check.
  4. Till Hörner uploaded patch set 2 V -1 09/21/26, 09:04

  5. Oliver Klee updated the commit message in patch set 3 09/21/26, 09:14

  6. core-ci voted on patch set 2 V +1 09/21/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108934

  7. Oliver Klee updated the commit message in patch set 4 09/21/26, 09:16

  8. core-ci voted on patch set 4 V +1 09/21/26, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108937

  9. core-ci voted on patch set 3 V +1 09/21/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108936

  10. Oliver Klee voted on patch set 4 CR +1 V +1 09/21/26, 09:40

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 09/21/26, 20:34

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 09/25/26, 08:32

  13. Stefan Bürk merged patch set 5 09/25/26, 09:10