Review main Merged

95989[TASK] Allow filtering e2e Playwright tests to a single file

Benni Mack CR +2 V +2 Easy +23 −5 updated 09/24/26, 17:38

Commit message

runTests.sh always ran the full Playwright e2e suite, forcing a full
docker/podman based instance boot plus all specs even when only a
single new or changed spec needed a quick check, unlike functional and
unit tests which already accept a path or "-- --filter" argument.

Forward trailing positional arguments (a spec file path, or other
Playwright CLI arguments such as "--grep <pattern>") to the underlying
"playwright test" invocation for the e2e, e2e-browser and e2e-prepare
suites, the same way "-s functional path/to/fileTest.php" already
works for PHP tests. The forwarded arguments are placed before
"--project", since Playwright parses "--project" as a variadic option
that would otherwise swallow a following file path as another project
name.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 09/23/26, 12:19

  2. Benni Mack updated the commit message in patch set 2 09/23/26, 12:22

  3. core-ci voted on patch set 1 V +1 09/23/26, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109050

  4. core-ci voted on patch set 2 V +1 09/23/26, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109051

  5. Wouter Wolters commented on patch set 2 09/23/26, 15:15

    I suggest to add an example to AGENTS.md. When an AI agent is working on a test it can also use the filter method easily to speed up development that way.
  6. Wouter Wolters uploaded patch set 3 V +1 09/23/26, 17:06

  7. Wouter Wolters voted on patch set 3 CR +1 V +1 09/23/26, 17:09

  8. core-ci voted on patch set 3 V +1 09/23/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109094

  9. Georg Ringer voted on patch set 3 CR +1 V +1 09/24/26, 17:10

  10. Benni Mack voted on patch set 3 CR +2 V +2 09/24/26, 17:38

  11. Benni Mack merged patch set 4 09/24/26, 17:38