Review main Merged

95996[BUGFIX] Skip Content-Length for unknown body size

Georg Ringer CR +2 V +2 Normal +90 −3 updated 09/23/26, 15:49

Commit message

PSR-7 explicitly allows a response body of unknown size:
StreamInterface::getSize() then returns NULL. The frontend
middleware casted that NULL to a string and thus sent an
empty Content-Length header, which breaks such responses,
for instance when they are handed over through a
PropagateResponseException.

The header is now omitted whenever the body size is unknown.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 09/23/26, 15:33

  2. Georg Ringer commented on patch set 1 09/23/26, 15:34

    This change is ready for review.
  3. Georg Ringer abandoned the change 09/23/26, 15:41

  4. Georg Ringer restored the change 09/23/26, 15:44

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 09/23/26, 15:45

  6. core-ci voted on patch set 1 V +1 09/23/26, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109070

  7. Benni Mack voted on patch set 1 CR +2 V +2 09/23/26, 15:49

  8. Benni Mack merged patch set 2 09/23/26, 15:49