Review 14.3 Merged

96003[BUGFIX] Handle links to CE correctly in Linkvalidator

Benni Mack CR +2 V +2 Normal +115 −1 updated 09/23/26, 16:41

Commit message

Typolinks pointing to a content element anchor of a page, of the
format t3://page?uid=1#2, were not parsed correctly for TCA fields
of type "link" (e.g. tt_content.header_link), unlike for fields
using the "typolink_tag" soft reference parser (e.g. bodytext).

The "typolink" soft reference parser returns two matches for such
a link: one for the page and one for the content element.
LinkAnalyzer::analyzeTypoLinks() (used for typolink_tag results)
already merges these into a single "pageAndAnchor" entry, but
analyzeLinks() (used for all other soft reference parsers) does
not, which made the report show the content element uid as if it
were the linked page.

Fields of TCA type "link" contain the typolink value directly and
do not need to go through the generic soft reference dispatch at
all. LinkAnalyzer::analyzeRecord() now detects them by their
TableColumnType::LINK type and hands them to a dedicated
analyzeTypolink() method, which reuses the "typolink" soft
reference parser directly and performs the same page/content
element merge as analyzeTypoLinks().

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 09/23/26, 16:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/23/26, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109087

  3. Benni Mack voted on patch set 1 CR +2 V +2 09/23/26, 16:41

  4. Benni Mack merged patch set 2 09/23/26, 16:41