Review main Merged

96011[BUGFIX] Support comma-separated allowAttributes in RteHtmlParser

Benni Mack CR +2 V +2 Easy +27 −3 updated 09/23/26, 18:46

Commit message

The RTE processing option "allowAttributes" only took effect in its
array form ("allowAttributes."). A comma-separated list, as accepted
by sibling options such as "allowTagsOutside", was silently ignored
and the default attribute list stayed in place.

Both notations are now evaluated. The option restricts the attributes
of <p> tags only, in contrast to "allowedAttribs" of HTMLparser_db,
which is configured per tag. The comments in Processing.yaml and the
property docblock now say so, and no longer refer to the non-existent
option "keepPDIVattribs".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Benni Mack uploaded patch set 1 09/23/26, 17:29

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 09/23/26, 17:32

  3. core-ci voted on patch set 1 V +1 09/23/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109099

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/23/26, 18:33

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/23/26, 18:46

  6. Benni Mack merged patch set 2 09/23/26, 18:46