Review main Merged

96025[BUGFIX] Allow disabling frontend indexing via EnableIndexingEvent

Benni Mack CR +2 V +2 Normal +243 −2 updated 09/24/26, 21:39

Commit message

EnableIndexingEvent could only force indexing of the current page.
There was no API to prevent indexing, for example for a plugin
showing GET-parameter based results that should not end up in the
index. The former workaround of setting index_enable on
$GLOBALS['TSFE']->config is no longer available.

The event now provides disableIndexing() and isIndexingDisabled().
A veto takes precedence over enableIndexing(), config.index_enable
and the disableFrontendIndexing extension setting.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 810

  1. Benni Mack uploaded patch set 1 09/24/26, 00:00

  2. core-ci voted on patch set 1 V +1 09/24/26, 00:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109119

  3. Benni Mack updated the commit message in patch set 2 V +1 09/24/26, 00:49

  4. core-ci voted on patch set 2 V +1 09/24/26, 00:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109123

  5. Georg Ringer commented on patch set 2 09/24/26, 05:13

    Important-100465-DisableFrontendIndexingViaEnableIndexingEvent.rst:1

    suggest changing that into a featuere and not important
  6. Benni Mack commented on patch set 2 09/24/26, 14:14

    Important-100465-DisableFrontendIndexingViaEnableIndexingEvent.rst:1 Reply

    yeah, I thought about that too, but it actually is more a "this is how it works in v14" because it worked in v13 as well in a different way.
  7. Georg Ringer voted on patch set 2 CR +1 V +1 09/24/26, 20:01

  8. Wouter Wolters voted on patch set 2 CR +1 V +1 09/24/26, 20:23

  9. Benni Mack commented on patch set 2 CR +2 V +2 09/24/26, 21:39

    Important-100465-DisableFrontendIndexingViaEnableIndexingEvent.rst:1 Reply

    Done
  10. Benni Mack merged patch set 3 09/24/26, 21:39