Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress

96032[WIP][TASK] Render CKEditor5 in shadow dom

Benjamin Franzke CR 0 V 0 Hard +214 −198 updated 11/09/26, 15:43

Commit message

Test shadow dom mode as requested upstream, see the
CKEditor issue referenced in the Forge issue.

TODO:
 * A new overlay container is needed in order for popups/"baloons"
   to be correctly positioned
   * Drawback: Styles need to be loaded twice
   * Check if this can be avoided, the current fallback does not work
 * Styles need to be moved into ckeditor5.scss in order to be set inside
   the shadow dom
   => check if all stylings still working

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/32/96032/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/32/96032/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 96032 [WIP][TASK] Render CKEditor5 in shadow dom This change

  2. main 97444[TASK] Update to CKEditor5 v49 This change is based on it Merged Benjamin Franzke CR +2 V +2 → 14.3, 13.4 Nightmare +2957 −2620

    The chain has patch set 2 of 3, the changes above it need a rebase.

Issues 1

Files 7

Review log 814

  1. Benjamin Franzke uploaded patch set 1 09/24/26, 11:20

  2. core-ci voted on patch set 1 V -1 09/24/26, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109149

  3. Benjamin Franzke uploaded patch set 2 V -1 09/24/26, 13:30

  4. core-ci voted on patch set 2 V +1 09/24/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109161

  5. Benjamin Franzke marked it work in progress 09/24/26, 13:53

  6. Benjamin Franzke uploaded patch set 3 V +1 10/08/26, 07:15

  7. Benjamin Franzke updated the commit message in patch set 4 10/08/26, 07:16

  8. core-ci voted on patch set 3 V +1 10/08/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110465

  9. core-ci voted on patch set 4 V +1 10/08/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110466

  10. Benjamin Franzke uploaded patch set 5 V +1 11/09/26, 14:57

  11. Benjamin Franzke marked it work in progress 11/09/26, 14:57

  12. core-ci voted on patch set 5 V -1 11/09/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113717

  13. Benjamin Franzke rebased onto patch set 6 V -1 11/09/26, 15:28

  14. core-ci voted on patch set 6 V +1 11/09/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113724