96041[TASK] Assert outcomes in core unit tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php2+12 −14
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Error/ErrorHandlerTest.php2+1 −0
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+22 −19
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php4+32 −5
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+1 −2
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+2 −8
Review log 911
-
Wouter Wolters uploaded patch set 1 09/24/26, 19:34
-
core-ci voted on patch set 1 V +1 09/24/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109178
-
Oliver Klee voted on patch set 1 V +1 09/24/26, 21:38
-
Oliver Klee commented on patch set 1 09/24/26, 21:45
ErrorHandlerTest.php:115We can use `self::assertNull()` here.PackageManagerTest.php:223We can use `assertEqualsCanonicalizing` instead, which will allow us to ditch the two `sort`s.PackageManagerTest.php:265Ditto. -
Wouter Wolters uploaded patch set 2
V +109/25/26, 16:32 -
Wouter Wolters commented on patch set 2 09/25/26, 16:33
PreviewModuleTest.php:91ReplyDoneErrorHandlerTest.php:115ReplyDonePackageManagerTest.php:223ReplyDonePackageManagerTest.php:265ReplyDone -
core-ci voted on patch set 2 V +1 09/25/26, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109271
-
Oliver Klee voted on patch set 2 CR +1 V +1 09/25/26, 17:04
-
Garvin Hicking voted on patch set 2 CR +1 V +1 09/25/26, 18:24
-
Stefan Bürk voted on patch set 2 CR +2 V +2 09/25/26, 20:04
-
Stefan Bürk merged patch set 3 09/25/26, 20:04
PreviewModuleTest.php:91