Review main Merged

96043[TASK] Make unit test assertions order sensitive

Wouter Wolters CR +2 V +2 Easy +15 −15 updated 09/25/26, 08:14

Commit message

Put expected values first in assertions for graphical functions,
array utilities, Extbase object access, extension dependencies, and
external link errors so failures show the correct difference.

Use assertSame for Fluid template paths and TypoScript arrays so
changed key order fails. Rename the template path test to describe
the ascending numeric order it expects.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 57

  1. Wouter Wolters uploaded patch set 1 09/24/26, 19:37

  2. core-ci voted on patch set 1 V +1 09/24/26, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109180

  3. Georg Ringer updated the commit message in patch set 2 V +1 09/24/26, 21:24

  4. Georg Ringer voted on patch set 2 CR +2 V +2 09/24/26, 21:24

  5. core-ci voted on patch set 2 V +1 09/24/26, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109191

  6. Oliver Klee voted on patch set 2 CR +1 V +1 09/24/26, 21:36

  7. Georg Ringer merged patch set 3 09/25/26, 08:14