Review main Merged

96044[TASK] Clean up file fixtures in unit tests

Wouter Wolters CR +2 V +2 Easy +4 −15 updated 09/25/26, 08:13

Commit message

Register the lock test fixture with testFilesToDelete under TYPO3's
var path, outside the lock directory. The framework then removes it
even when an assertion fails.

Remove the rotating writer helper that deleted the file just after
the test created it. Construct the writer directly so the test covers
writing to an existing log file.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Wouter Wolters uploaded patch set 1 09/24/26, 19:38

  2. core-ci voted on patch set 1 V +1 09/24/26, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109181

  3. Georg Ringer updated the commit message in patch set 2 V +1 09/24/26, 20:42

  4. Georg Ringer voted on patch set 2 CR +2 V +2 09/24/26, 20:42

  5. core-ci voted on patch set 2 V +1 09/24/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109187

  6. Oliver Klee voted on patch set 2 CR +1 V +1 09/24/26, 21:37

  7. Georg Ringer merged patch set 3 09/25/26, 08:13