Review main Merged

96072[BUGFIX] Guard page tree labels against NULL page titles

Wolfgang Klinger CR +2 V +2 Easy +2 −2 updated 09/25/26, 17:45

Commit message

TreeController reads pages.title for the tree items and for the
mount point path without a null guard, while the nav_title check
right next to it already has one. A NULL title then reaches trim()
and htmlspecialchars() with null.

Both assignments now fall back to an empty string, so such rows
get the "[No title]" label like rows with an empty title.

No test is added on purpose. The TCA generated schema declares
both columns NOT NULL, so the case only occurs on installations
whose database deviates from the schema.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Wolfgang Klinger uploaded patch set 1 09/25/26, 12:57

  2. core-ci voted on patch set 1 V +1 09/25/26, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109246

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 09/25/26, 15:54

  4. Oliver Klee voted on patch set 1 CR +1 09/25/26, 16:25

  5. Oliver Klee voted on patch set 1 V +1 09/25/26, 16:25

  6. Wouter Wolters voted on patch set 1 CR +1 V +1 09/25/26, 16:44

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 09/25/26, 17:36

  8. Stefan Bürk merged patch set 2 09/25/26, 17:45