Review main Ready for review Quiet

96075[BUGFIX] Apply existing CSP resolutions to further reports

Wolfgang Klinger CR 0 V 0 Normal +101 −6 updated 09/25/26, 13:26

Commit message

Applying a mutation suggestion in the CSP backend module answered
with an empty JSON body when a resolution with the same summary
already existed, or when no report matched the given summaries.
The module then failed with "uuids is not iterable", and in the
first case the reports were never marked as handled, so every
further attempt failed the same way.

An existing resolution is now reused and the matching reports are
handled as on the first apply. Without matching reports the
response carries an empty uuid list.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/75/96075/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/75/96075/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 2

Review log 12

  1. Wolfgang Klinger uploaded patch set 1 09/25/26, 13:17

  2. core-ci voted on patch set 1 V +1 09/25/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109249