Review main Merged

96076[TASK] Show redirect creator in the redirects module

Oli Bartsch CR +2 V +2 Hard +440 −21 updated 10/01/26, 07:37

Commit message

The creation information, added with #107755, is so far
only visible when editing a redirect record. The module
listing now shows it as well, in a "Created" column,
displaying the avatar and the name of the backend user
together with the creation date.

The column is sortable by creation date, and the module
filter has been extended by a "Created by" select box,
to list the redirects of a single backend user only.

Creators without a backend user record, because they
were never tracked or have been deleted meanwhile, are
labelled as such.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 15

Review log 1723

  1. Oli Bartsch uploaded patch set 1 09/25/26, 14:33

  2. core-ci voted on patch set 1 V +1 09/25/26, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109252

  3. Stefan Bürk commented on patch set 1 09/25/26, 19:08

    Reviewing ...
  4. Stefan Bürk uploaded patch set 2 V +1 09/25/26, 19:40

  5. core-ci voted on patch set 2 V +1 09/25/26, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109301

  6. Stefan Bürk commented on patch set 2 09/25/26, 19:54

    Reply

    Pushed some minor nits. Done (expect open questions, see other comments).

    ManagementController.php:156

    Every creator uid that cannot be resolves, because the user has been deleted or never had a existing `be_users` record, will be rendered with the same label .. that means, if multiple such users exists we would have multipe (`user_not_found`) labels. I guess we need to put some brain into that and consider another approach here: * (a) add the uid next to the user not found label -> `Not found (non-existent user) [123]` * (b) having a aggregate in the select box (e.x. `-2`) for `Not found (non-existent user)`, modifying the query to have the "created_by` calcualted with a `IF()` on joined `be_users` table (left join) and in case of not existing or (soft) deleted use hardcoded `-2`, otherwise the uid. What do you think ?

    ManagementController.php:169

    This renders the avatar for all users (creators) for the redirect type, even if not displayed on the "current" pagination page of the management list. Do we not have a fluid viewhelper for user avatar rendering ? In that case we only need to provide the required datan in this array and use it in the fluid template, which would possible reduce rendered avatars. Avatar render service already caches it per requerst for one users, so even with x-times the same users it would only be fetched one time. Or we need to build/enrich the avatars only for the users of the records on the current page. What do you think ?
  7. Oli Bartsch uploaded patch set 3 V +1 09/26/26, 06:03

  8. Oli Bartsch commented on patch set 3 09/26/26, 06:06

    Reply

    Hey, I pushed a new patchset. I deliberately added the new language key for having not found and not tracked streamlined. Furthermore, I also deliberately skipped those AI generated code comments which IMO do not bring much benefit.

    ManagementController.php:156 Reply

    Ok. Creators without an existing be_users record now share one filter value (Demand::CREATOR_NOT_FOUND) and untracked stays separate. The options are keyed by that filter value, so duplicates collapse on their own, while rows still look up by uid. Constraint is a subquery instead of a join.

    ManagementController.php:169 Reply

    Yes, avatars are now only built for the creators of the redirects on the current page, labels still for all, since the filter needs them. The AvatarViewHelper takes only a uid and does getRestrictions()->removeAll(), so it renders avatars for deleted users. That's the case this patch deliberately hides (neither name nor avatar). It also has no argument for an already-fetched record, so it would re-query be_users once per row instead of once per request.
  9. core-ci voted on patch set 3 V +1 09/26/26, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109321

  10. Oli Bartsch rebased onto patch set 4 V +1 09/28/26, 07:04

  11. core-ci voted on patch set 4 V +1 09/28/26, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109397

  12. Georg Ringer voted on patch set 4 CR +1 V +1 09/28/26, 18:51

  13. Oli Bartsch uploaded patch set 5 CR +1 V +1 09/28/26, 21:00

  14. core-ci voted on patch set 5 V -1 09/28/26, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109455

  15. Oli Bartsch rebased onto patch set 6 V -1 09/28/26, 21:50

  16. core-ci voted on patch set 6 V +1 09/28/26, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109465

  17. Georg Ringer voted on patch set 6 CR +1 V +1 09/28/26, 22:00

  18. Josua Vogel commented on patch set 6 09/29/26, 13:35

    Should the author and the creation date be listed separately?
  19. Oli Bartsch commented on patch set 6 09/29/26, 15:27

    Reply

    Not in my opinion. It was done this way to be consitent with the info shown in the publish module.
  20. Josua Vogel commented on patch set 6 09/29/26, 17:13

    Reply

    Yes, I don’t have a strong opinion. But at first glance I wondered, it it sorts by user name or creation date :)
  21. Benni Mack commented on patch set 6 CR +1 V +1 10/01/26, 07:05

    Reply

    lets go with this for now.
  22. Oli Bartsch voted on patch set 6 CR +2 V +2 10/01/26, 07:37

  23. Oli Bartsch merged patch set 7 10/01/26, 07:37