Review main Merged

96093[BUGFIX] Keep daily task time across DST changes

Benni Mack CR +2 V +2 Normal +140 −2 updated 09/27/26, 10:23

Commit message

Recurring scheduler tasks with an interval were calculated by pure
timestamp arithmetic. A daily task (86400 seconds) started at 23:59
in a timezone with daylight saving time therefore ran at 00:59 after
the switch to summer time, and at 22:59 after the switch back.

Intervals that are a whole number of days are now stepped in local
time, so the wall-clock time of the task is kept. Other intervals,
such as hourly ones, stay strictly periodic.

The calculation moves into a separate method that takes the reference
time, which makes it testable. The PHP default timezone is used, which
is to be replaced by the backend user timezone later.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack uploaded patch set 1 09/25/26, 19:27

  2. core-ci voted on patch set 1 V +1 09/25/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109300

  3. Oliver Klee voted on patch set 1 V +1 09/25/26, 20:07

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/26/26, 06:18

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 09/26/26, 14:59

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/26/26, 21:14

  7. Garvin Hicking voted on patch set 1 CR +2 V +2 09/27/26, 09:02

  8. Garvin Hicking merged patch set 2 09/27/26, 10:23