Review main Merged

96099[TASK] Add validator configuration DTOs

Josua Vogel CR +2 V +2 Hard +703 −197 updated 10/14/26, 16:20

Commit message

Model validator definitions as typed DTOs, and use them when
converting and consuming form prototype configuration.

Represent formEditor.propertyCollections as a map of named
collections. Since #110803 the collection names were read as
entries, so their identifier was always null and multi-value
finisher properties were not converted for the form editor.
This regression is fixed along the way.

FormDefinition::getTypeDefinitions() and getValidatorsDefinition()
now return DTO collections instead of arrays. Both are internal.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wolfgang Klinger +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wolfgang Klinger +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 23

Show 3 more files

Review log 2641

Show 916 earlier messages
  1. Josua Vogel uploaded patch set 1 09/26/26, 09:09

  2. Josua Vogel marked it work in progress 09/26/26, 09:09

  3. core-ci voted on patch set 1 V -1 09/26/26, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109326

  4. Josua Vogel uploaded patch set 2 V -1 09/30/26, 15:40

  5. Josua Vogel uploaded patch set 3 09/30/26, 15:45

  6. core-ci voted on patch set 2 V -1 09/30/26, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109663

  7. core-ci voted on patch set 3 V -1 09/30/26, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109668

  8. Josua Vogel commented on patch set 4 V -1 10/01/26, 12:56

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 10/01/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109794

  10. Josua Vogel updated the commit message in patch set 5 V +1 10/01/26, 13:12

  11. Josua Vogel commented on patch set 5 10/01/26, 13:18

    This change is ready for review.
  12. core-ci voted on patch set 5 V +1 10/01/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109796

  13. Josua Vogel uploaded patch set 6 V +1 10/01/26, 14:21

  14. core-ci voted on patch set 6 V +1 10/01/26, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109808

  15. Josua Vogel rebased onto patch set 7 V +1 10/02/26, 13:24

  16. core-ci voted on patch set 7 V +1 10/02/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109945

  1. Josua Vogel rebased onto patch set 8 V +1 10/05/26, 05:54

  2. core-ci voted on patch set 8 V +1 10/05/26, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110067

  3. Josua Vogel rebased onto patch set 9 V +1 10/05/26, 18:08

  4. core-ci voted on patch set 9 V +1 10/05/26, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110140

  5. Josua Vogel rebased onto patch set 10 V +1 10/07/26, 05:04

  6. core-ci voted on patch set 10 V +1 10/07/26, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110285

  7. Josua Vogel rebased onto patch set 11 V +1 10/07/26, 20:40

  8. core-ci voted on patch set 11 V +1 10/07/26, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110411

  9. Josua Vogel rebased onto patch set 12 V +1 10/09/26, 09:29

  10. core-ci voted on patch set 12 V +1 10/09/26, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110577

  11. Josua Vogel rebased onto patch set 13 V +1 10/12/26, 19:58

  12. core-ci voted on patch set 13 V +1 10/12/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110946

  13. Benni Mack voted on patch set 13 CR +1 V +1 10/13/26, 16:17

  14. Josua Vogel uploaded patch set 14 CR +1 V +1 10/14/26, 06:16

  15. core-ci voted on patch set 14 V +1 10/14/26, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111041

  16. Benni Mack voted on patch set 14 CR +1 V +1 10/14/26, 07:05

  17. Wolfgang Klinger commented on patch set 14 CR -1 10/14/26, 08:48

    Nice, the validator DTOs fit well with the finisher ones. Two things though. The propertyCollections part is actually a bugfix: since 6316aee5746 the DTO took the collection names as entries, so the identifier was always null and multi-value finisher properties never got converted in the editor. Your new controller test shows exactly that. Please mention it in the commit message, right now it reads like a pure refactoring. And I'm not sure we need FormElementPropertyValidatorDefinition + collection. They are only used in getFormEditorDefinitions() and get turned back into getRaw() right there. The untyped fallback already does the same. I'd leave them out for now (YAGNI). FormDefinition.php L665: These two getters now return collections instead of arrays. They are internal, but custom element factories out there use them. Maybe worth a line in the commit message. PropertyCollectionDefinitionCollection.php L68: Same null/empty check as in FormDefinitionConversionService. If fromArray() turns '' into null, both can go.
  18. Josua Vogel uploaded patch set 15 CR +1 V +1 10/14/26, 10:06

  19. core-ci voted on patch set 15 V +1 10/14/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111082

  20. Josua Vogel commented on patch set 15 10/14/26, 10:51

    Reply

    Done
  21. Benni Mack voted on patch set 15 CR +1 V +1 10/14/26, 12:36

  22. Wolfgang Klinger voted on patch set 15 CR +1 V +1 10/14/26, 12:50

  23. Simon Schaufelberger voted on patch set 15 CR +1 V +1 10/14/26, 14:40

  24. Benni Mack voted on patch set 15 CR +2 V +2 10/14/26, 16:20

  25. Benni Mack merged patch set 16 10/14/26, 16:20