96099[TASK] Add validator configuration DTOs
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wolfgang Klinger +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Wolfgang Klinger +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 23
- typo3/sysext/form/Classes/Controller/FormEditorController.php+15 −29
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −4
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+16 −10
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+19 −19
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/FormEditorDefinition.php+4 −12
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/FormElementDefinition.php+3 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/PropertyCollectionDefinition.php+1 −1
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/PropertyCollectionDefinitionCollection.php+8 −4
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/PropertyCollectionsDefinition.phpnew+65 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/PrototypeConfiguration.php+81 −30
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/ValidatorDefinition.phpnew+58 −0
- typo3/sysext/form/Classes/Domain/DTO/FormConfiguration/Prototype/ValidatorDefinitionCollection.phpnew+64 −0
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+1 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+7 −10
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+4 −4
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+37 −40
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+1 −1
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+87 −13
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.php+7 −6
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+5 −4
Show 3 more files
- typo3/sysext/form/Tests/Unit/Domain/DTO/FormConfiguration/Prototype/FormEditorDefinitionTest.php+53 −7
- typo3/sysext/form/Tests/Unit/Domain/DTO/FormConfiguration/Prototype/PrototypeConfigurationTest.php+74 −2
- typo3/sysext/form/Tests/Unit/Domain/DTO/FormConfiguration/Prototype/ValidatorDefinitionCollectionTest.phpnew+92 −0
Review log 2641
Show 916 earlier messages
-
Josua Vogel uploaded patch set 1 09/26/26, 09:09
-
Josua Vogel marked it work in progress 09/26/26, 09:09
-
core-ci voted on patch set 1 V -1 09/26/26, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109326
-
Josua Vogel uploaded patch set 2
V -109/30/26, 15:40 -
Josua Vogel uploaded patch set 3 09/30/26, 15:45
-
core-ci voted on patch set 2 V -1 09/30/26, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109663
-
core-ci voted on patch set 3 V -1 09/30/26, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109668
-
Josua Vogel commented on patch set 4
V -110/01/26, 12:56Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 10/01/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109794
-
Josua Vogel updated the commit message in patch set 5
V +110/01/26, 13:12 -
Josua Vogel commented on patch set 5 10/01/26, 13:18
This change is ready for review. -
core-ci voted on patch set 5 V +1 10/01/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109796
-
Josua Vogel uploaded patch set 6
V +110/01/26, 14:21 -
core-ci voted on patch set 6 V +1 10/01/26, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109808
-
Josua Vogel rebased onto patch set 7
V +110/02/26, 13:24 -
core-ci voted on patch set 7 V +1 10/02/26, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109945
-
Josua Vogel rebased onto patch set 8
V +110/05/26, 05:54 -
core-ci voted on patch set 8 V +1 10/05/26, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110067
-
Josua Vogel rebased onto patch set 9
V +110/05/26, 18:08 -
core-ci voted on patch set 9 V +1 10/05/26, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110140
-
Josua Vogel rebased onto patch set 10
V +110/07/26, 05:04 -
core-ci voted on patch set 10 V +1 10/07/26, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110285
-
Josua Vogel rebased onto patch set 11
V +110/07/26, 20:40 -
core-ci voted on patch set 11 V +1 10/07/26, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110411
-
Josua Vogel rebased onto patch set 12
V +110/09/26, 09:29 -
core-ci voted on patch set 12 V +1 10/09/26, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110577
-
Josua Vogel rebased onto patch set 13
V +110/12/26, 19:58 -
core-ci voted on patch set 13 V +1 10/12/26, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110946
-
Benni Mack voted on patch set 13 CR +1 V +1 10/13/26, 16:17
-
Josua Vogel uploaded patch set 14
CR +1V +110/14/26, 06:16 -
core-ci voted on patch set 14 V +1 10/14/26, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111041
-
Benni Mack voted on patch set 14 CR +1 V +1 10/14/26, 07:05
-
Wolfgang Klinger commented on patch set 14 CR -1 10/14/26, 08:48
Nice, the validator DTOs fit well with the finisher ones. Two things though. The propertyCollections part is actually a bugfix: since 6316aee5746 the DTO took the collection names as entries, so the identifier was always null and multi-value finisher properties never got converted in the editor. Your new controller test shows exactly that. Please mention it in the commit message, right now it reads like a pure refactoring. And I'm not sure we need FormElementPropertyValidatorDefinition + collection. They are only used in getFormEditorDefinitions() and get turned back into getRaw() right there. The untyped fallback already does the same. I'd leave them out for now (YAGNI). FormDefinition.php L665: These two getters now return collections instead of arrays. They are internal, but custom element factories out there use them. Maybe worth a line in the commit message. PropertyCollectionDefinitionCollection.php L68: Same null/empty check as in FormDefinitionConversionService. If fromArray() turns '' into null, both can go. -
Josua Vogel uploaded patch set 15
CR +1V +110/14/26, 10:06 -
core-ci voted on patch set 15 V +1 10/14/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111082
-
Josua Vogel commented on patch set 15 10/14/26, 10:51
Reply
Done -
Benni Mack voted on patch set 15 CR +1 V +1 10/14/26, 12:36
-
Wolfgang Klinger voted on patch set 15 CR +1 V +1 10/14/26, 12:50
-
Simon Schaufelberger voted on patch set 15 CR +1 V +1 10/14/26, 14:40
-
Benni Mack voted on patch set 15 CR +2 V +2 10/14/26, 16:20
-
Benni Mack merged patch set 16 10/14/26, 16:20