Review main Merged

96109[BUGFIX] Count joined records for select total

Wouter Wolters CR +2 V +2 Normal +81 −38 updated 09/28/26, 18:16

Commit message

Build the total-count query from the configured select query so joins
and conditions on joined tables are included in the count.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Wouter Wolters uploaded patch set 1 09/27/26, 09:38

  2. core-ci voted on patch set 1 V +1 09/27/26, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109365

  3. Benni Mack commented on patch set 1 CR +1 V +1 09/28/26, 14:39

    nice one (so easy) and good catch.
  4. Josua Vogel voted on patch set 1 CR +1 09/28/26, 14:48

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/28/26, 18:16

  6. Benni Mack merged patch set 2 09/28/26, 18:16