Review 13.4 Merged

96112[BUGFIX] Fix Extension Scanner rule for returnWebmounts()

Garvin Hicking CR +2 V +2 Easy +7 −7 updated 09/27/26, 10:56

Commit message

The rule meant to detect calls to the removed method
BackendUserAuthentication::returnWebmounts() can never match. It has
two defects: the method name is missing its trailing "s", and the rule
is registered in MethodCallStaticMatcher although the method is not
static but a regular instance method.

The entry is moved to MethodCallMatcher with the plural name and "->"
syntax, next to the other rules of the same removal. The referenced
changelog files stay unchanged.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Garvin Hicking commented on patch set 1 09/27/26, 10:39

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php
  2. Garvin Hicking uploaded patch set 2 09/27/26, 10:44

    backport
  3. Garvin Hicking marked it ready for review 09/27/26, 10:45

  4. core-ci voted on patch set 1 V -1 09/27/26, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109369

  5. core-ci voted on patch set 2 V +1 09/27/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109370

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 09/27/26, 10:56

  7. Garvin Hicking merged patch set 3 09/27/26, 10:56